[GitHub] activemq-artemis pull request #1641: Sorting issue with BeanUtils picking up...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1641: Sorting issue with BeanUtils picking up...

michaelandrepearce-2
GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1641

    Sorting issue with BeanUtils picking up set/get props in JNDI - WIP-DO NOT MERGE

    Apply fix so that when using JNDI via tomcat resource it works.
    Replace original extract of JNDIStorable taken from Qpid, and use ActiveMQ5's as fits better to address this issue. (which primary use case is users migrating from 5.x)
    Refactored ActiveMQConnectionFactory to externalise and turn into reference by StringRefAddr's instead of custom RefAddr which isnt standard.
    Refactored ActiveMQDestinations similar
    Refactored ActiveMQDestination to remove redundent and duplicated name field and ensured getters still behave the same

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis fix_jndi_tomcat_resource

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1641.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1641
   
----
commit d90294ad69c08f43e244b2ec9f8a4d3acf71293c
Author: Michael André Pearce <[hidden email]>
Date:   2017-11-04T02:26:39Z

    JNDI Tomcat Resource Properties
   
    Apply fix so that when using JNDI via tomcat resource it works.
    Replace original extract of JNDIStorable taken from Qpid, and use ActiveMQ5's as fits better to address this issue. (which primary use case is users migrating from 5.x)
    Refactored ActiveMQConnectionFactory to externalise and turn into reference by StringRefAddr's instead of custom RefAddr which isnt standard.
    Refactored ActiveMQDestinations similar
    Refactored ActiveMQDestination to remove redundent and duplicated name field and ensured getters still behave the same

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1641: Sorting issue with BeanUtils picking up...

michaelandrepearce-2
Github user michaelandrepearce closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1641


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1641: Sorting issue with BeanUtils picking up set/ge...

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1641
 
    Why close it ?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1641: Sorting issue with BeanUtils picking up set/ge...

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1641
 
    Still needs work, eg need to add tests so it doesn’t get regressed in future etc, add some documentation like there is in 5.x. Also I’d like @spaction to check it fixes it for him incase it doesn’t and I need to do some further refractors


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1641: Sorting issue with BeanUtils picking up set/ge...

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1641
 
    *refactors


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1641: Sorting issue with BeanUtils picking up set/ge...

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1641
 
    Should I leave it open whilst I do that then? @clebertsuconic? Also do you think I should seperate documentation from the fix/improvement then?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1641: Sorting issue with BeanUtils picking up set/ge...

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1641
 
    @michaelandrepearce I thought you had given up.. :)
   
    also, the thing is.. if you close it... later you will need to open a new PR...
    github doesn't do well when the head changed against your closed PR.. I haven't seen it working at least. (maybe the behaviour has changed).
   
    If you want to close it now.. and open a new one later .. it's up to you.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1641: Sorting issue with BeanUtils picking up set/ge...

michaelandrepearce-2
In reply to this post by michaelandrepearce-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1641
 
    Haha no def not given up, :)
   
    I'll open a new PR once it's been checked by the user that it works, ill work on docs and extra tests in mean time. I'll have to create a jira and amend commit text anyhow.


---