[GitHub] activemq-artemis pull request #1640: DO NOT MERGE JUST WANT TO CHECK BUILD o...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1640: DO NOT MERGE JUST WANT TO CHECK BUILD o...

asfgit
GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1640

    DO NOT MERGE JUST WANT TO CHECK BUILD on linux (local laptop is OS X) - WIP

    Apply fix so that when using JNDI via tomcat resource it works.
    Replace original extract of JNDIStorable taken from Qpid, and use ActiveMQ5's as fits better to address this issue. (which primary use case is users migrating from 5.x)
    Refactored ActiveMQConnectionFactory to externalise and turn into reference by StringRefAddr's instead of custom RefAddr which isnt standard.
    Refactored ActiveMQDestinations similar
    Refactored ActiveMQDestination to remove redundent and duplicated name field and ensured getters still behave the same

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis fix_jndi_tomcat_resource

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1640.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1640
   
----
commit 09682d7ce7e9dca1c664ac13a882dc51be9e1ad9
Author: Michael André Pearce <[hidden email]>
Date:   2017-11-04T02:26:39Z

    JNDI Tomcat Resource Properties
   
    Apply fix so that when using JNDI via tomcat resource it works.
    Replace original extract of JNDIStorable taken from Qpid, and use ActiveMQ5's as fits better to address this issue. (which primary use case is users migrating from 5.x)
    Refactored ActiveMQConnectionFactory to externalise and turn into reference by StringRefAddr's instead of custom RefAddr which isnt standard.
    Refactored ActiveMQDestinations similar
    Refactored ActiveMQDestination to remove redundent and duplicated name field and ensured getters still behave the same

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1640: DO NOT MERGE JUST WANT TO CHECK BUILD o...

asfgit
Github user michaelandrepearce closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1640


---