[GitHub] activemq-artemis pull request #1634: Removed quotation marks from if stateme...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1634: Removed quotation marks from if stateme...

pgfox
GitHub user Haydend opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1634

    Removed quotation marks from if statement in artemis.cmd

    These were causing an error when %ARTEMIS_HOME% string contains quotes also, for example : "C:\Program Files\Apache\Artemis\apache-artemis-2.3.0"
   
    Error produced :
    C:\>artemis
    Files\Apache\Artemis\apache-artemis-2.3.0""=="" was unexpected at this time.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Haydend/activemq-artemis SPACE_FIX

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1634.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1634
   
----
commit 1c5a82531fd4027abe6023e85f9e00a2cf4048e3
Author: Hayden Dunnicliffe <[hidden email]>
Date:   2017-11-02T16:10:25Z

    Removed quotation marks from if statement in artemis.cmd
    These were causing an error when %ARTEMIS_HOME% string contains quotes also, for example : "C:\Program Files\Apache\Artemis\apache-artemis-2.3.0"

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1634: Removed quotation marks from if statement in a...

pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1634
 
    I don’t see this error.  
   
    Please give us right steps to produce the error you saw.
   
   
    Perhaps you should discuss on users or dev list.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1634: Removed quotation marks from if statement in a...

pgfox
In reply to this post by pgfox
Github user Haydend commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1634
 
    Running on Windows 10
    %ARTEMIS_HOME% is set to "C:\Program Files\Apache\Artemis\apache-artemis-2.3.0"
    That's including the quote marks, so that when you run "echo %ARTEMIS_HOME%" the following is returned:
    "C:\Program Files\Apache\Artemis\apache-artemis-2.3.0"
   
    %PATH% is modified to include : %ARTEMIS_HOME%\bin
   
    Open new CMD window and run "artemis", without the modified artemis.cmd file I get the following returned:
    Files\Apache\Artemis\apache-artemis-2.3.0""=="" was unexpected at this time.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1634: Removed quotation marks from if statement in a...

pgfox
In reply to this post by pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1634
 
    How do you set it on your artemis.profile ?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1634: Removed quotation marks from if statement in a...

pgfox
In reply to this post by pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1634
 
    Are you setting this with command line as opposed to the profile ?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1634: Removed quotation marks from if statement in a...

pgfox
In reply to this post by pgfox
Github user Haydend commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1634
 
    Sorry, I'm not sure what you are asking. This is a fresh install and have not touched the artemis.profile. It is not installed as a service. I'm setting it up as a development instance on my local machine, thus will run it within a command prompt on my desktop.
   
     ARTEMIS_HOME is set as a System Environment Variable in Windows.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1634: Removed quotation marks from if statement in a...

pgfox
In reply to this post by pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1634
 
    Usually we don’t do that.  You just call artemis.cmd and it will read the artemis.profile.
   
    It seems this is break other usage.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1634: Removed quotation marks from if statement in a...

pgfox
In reply to this post by pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1634
 
    @Haydend you don't need to set ARTEMIS.HOME as a variable.
   
    All you do is:
   
   
    from where you installed artemis:
   
    "c:\program files\activemq-artemis\bin\artemis.cmd" create "c:\anywhereyouwant\"
   
   
    set PATH=%PATH%;c:anywhereyouwant\bin
   
   
    artemis.cmd
   
   
    and it should work...
   
    once you set the path, the ARTEMIS_INSTANCE is picked from the profile where that cmd is located at.
   
   
   
   
    we could change to have the variable defined.. but it would be more work on that... as I see your script is not working every usage. (like running from the bin directly for instance).



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1634: Removed quotation marks from if statement in a...

pgfox
In reply to this post by pgfox
Github user Haydend commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1634
 
    Understood, thank you for your time looking into this. I will close the PR.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1634: Removed quotation marks from if stateme...

pgfox
In reply to this post by pgfox
Github user Haydend closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1634


---