[GitHub] activemq-artemis pull request #1630: NO-JIRA updating release documentation

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1630: NO-JIRA updating release documentation

pgfox
GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1630

    NO-JIRA updating release documentation

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis master_work

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1630.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1630
   
----
commit c9ace2efe2954ac48c5199e64ddb67d743dc4cca
Author: Justin Bertram <[hidden email]>
Date:   2017-11-01T19:24:48Z

    NO-JIRA updating release documentation

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1630: NO-JIRA updating release documentation

pgfox
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1630#discussion_r148524207
 
    --- Diff: RELEASING.md ---
    @@ -16,16 +16,32 @@ Things to do before issuing a new release:
     
     * Test the standalone release (this should be done on windows as well as linux):
     1. Unpack the distribution zip or tar.gz
    -2. Start and stop the server (run.sh and stop.sh) for each configuration
    +2. Start and stop the server
     3. Run the examples (follow the instructions under examples/index.html)
     5. Check the manuals have been created properly
     6. Check the javadocs are created correctly (including the diagrams)
     
    -* If every thing is successful.  Follow the Apache guide (http://www.apache.org/dev/publishing-maven-artifacts.html) to build and publish artifacts to Nexus and send out a release vote.
    --- End diff --
   
    I think we should keep that reference...
   
    At least keep this as a note: this is based on http://www.apache.org/dev/publishing-maven-artifacts.html


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1630: NO-JIRA updating release documentation

pgfox
In reply to this post by pgfox
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1630


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1630: NO-JIRA updating release documentation

pgfox
In reply to this post by pgfox
Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1630#discussion_r148774957
 
    --- Diff: RELEASING.md ---
    @@ -93,11 +133,15 @@ scm.tag=1.4.0
     
     ## Removing additional files
     
    -Note: There is one additional step to remove the activemq-pom-<version>-source-release.zip from the Nexus staging repository before closing the staging repository.  At the moment this artifact is uploaded automatically by the Apache release plugin.  In future versions the ActiveMQ Artemis pom will be updated to take this into account.
    +The last step before closing the staging repository is removing the activemq-pom-&lt;version>-source-release.zip.  At
    +the moment this artifact is uploaded automatically by the Apache release plugin. In future versions the ActiveMQ Artemis
    --- End diff --
   
    This can be avoided by overriding the profile and preventing the generation, e.g. see: https://github.com/apache/qpid-jms/blob/0.27.0/pom.xml#L326


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1630: NO-JIRA updating release documentation

pgfox
In reply to this post by pgfox
Github user gemmellr commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1630#discussion_r148774726
 
    --- Diff: RELEASING.md ---
    @@ -62,12 +86,26 @@ What is SCM release tag or label for "ActiveMQ Artemis Parent"? (org.apache.acti
     What is the new development version for "ActiveMQ Artemis Parent"? (org.apache.activemq:artemis-pom) 1.4.1-SNAPSHOT: : 1.5.0-SNAPSHOT
     ```
     
    -Otherwise snapshots will be created at 1.4.1 and forgotten. (Unless we ever elease 1.4.1 on that example).
    +Otherwise snapshots will be created at 1.4.1 and forgotten. (Unless we ever release 1.4.1 on that example).
     
     For more information look at the prepare plugin:
     
     - http://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html#pushChanges
     
    +If you set `pushChanges=false` then you will have to push the changes manually.  The first command is to push the commits
    +which are for changing the `&lt;version>` in the pom.xml files, and the second push is for the tag, e.g.:
    +
    +```sh
    +git push upstream
    +git push upstream <version>
    +```
    +
    +
    +## Extra tests
    +
    +Note: The Apache Release plugin does not bump the version on the `extraTests` module.  Release manager should manually
    --- End diff --
   
    Perhaps the poms should be fixed so that it does. I presume its skipped over because the module is not actually enabled at the time, so perhaps it can be updated to be enabled during the release and allow it to be updated, without actually doing anything else (e.g it needn't be deployed etc).


---