[GitHub] activemq-artemis pull request #1623: ARTEMIS-1488 add 'all' client jar to di...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1623: ARTEMIS-1488 add 'all' client jar to di...

pgfox
GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1623

    ARTEMIS-1488 add 'all' client jar to distribution

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1488

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1623.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1623
   
----
commit b72f94c59f88c94b5ed61ef36ffdc09a00a768dd
Author: Justin Bertram <[hidden email]>
Date:   2017-10-30T14:48:07Z

    ARTEMIS-1488 add 'all' client jar to distribution

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1623: ARTEMIS-1488 add 'all' client jar to di...

pgfox
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1623#discussion_r147759750
 
    --- Diff: artemis-distribution/pom.xml ---
    @@ -39,6 +39,11 @@
          <!-- ActiveMQ Artemis artifacts -->
           <dependency>
              <groupId>org.apache.activemq</groupId>
    +         <artifactId>artemis-jms-client-all</artifactId>
    --- End diff --
   
    You beat me to it, have a version myself locally just hadn’t had time to commit it.
   
    What about inc the core client all jar also?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1623: ARTEMIS-1488 add 'all' client jar to di...

pgfox
In reply to this post by pgfox
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1623#discussion_r147763425
 
    --- Diff: artemis-distribution/pom.xml ---
    @@ -39,6 +39,11 @@
          <!-- ActiveMQ Artemis artifacts -->
           <dependency>
              <groupId>org.apache.activemq</groupId>
    +         <artifactId>artemis-jms-client-all</artifactId>
    --- End diff --
   
    My thought here was to keep it really simple so instead of having a JMS client and a core client having just the JMS client which (by design) includes the core client.  The JMS client is just around 300KB larger.  In a future release I think we'll get ride of the core and JMS "all" clients and just have a single artemis-client-all which will actually just be the JMS "all" client but renamed to be less confusing.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1623: ARTEMIS-1488 add 'all' client jar to di...

pgfox
In reply to this post by pgfox
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1623#discussion_r147765072
 
    --- Diff: artemis-distribution/pom.xml ---
    @@ -39,6 +39,11 @@
          <!-- ActiveMQ Artemis artifacts -->
           <dependency>
              <groupId>org.apache.activemq</groupId>
    +         <artifactId>artemis-jms-client-all</artifactId>
    --- End diff --
   
    That’s a good point / idea. How close are we to release/tag is it would maybe doing that now? I can try do it tonight.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1623: ARTEMIS-1488 add 'all' client jar to di...

pgfox
In reply to this post by pgfox
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1623#discussion_r147765471
 
    --- Diff: artemis-distribution/pom.xml ---
    @@ -39,6 +39,11 @@
          <!-- ActiveMQ Artemis artifacts -->
           <dependency>
              <groupId>org.apache.activemq</groupId>
    +         <artifactId>artemis-jms-client-all</artifactId>
    --- End diff --
   
    Would = worth


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1623: ARTEMIS-1488 add 'all' client jar to di...

pgfox
In reply to this post by pgfox
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1623#discussion_r147765726
 
    --- Diff: artemis-distribution/pom.xml ---
    @@ -39,6 +39,11 @@
          <!-- ActiveMQ Artemis artifacts -->
           <dependency>
              <groupId>org.apache.activemq</groupId>
    +         <artifactId>artemis-jms-client-all</artifactId>
    --- End diff --
   
    Btw +1 (with or without suggested change by you) happy if this is merged.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1623: ARTEMIS-1488 add 'all' client jar to di...

pgfox
In reply to this post by pgfox
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1623#discussion_r147768193
 
    --- Diff: artemis-distribution/pom.xml ---
    @@ -39,6 +39,11 @@
          <!-- ActiveMQ Artemis artifacts -->
           <dependency>
              <groupId>org.apache.activemq</groupId>
    +         <artifactId>artemis-jms-client-all</artifactId>
    --- End diff --
   
    I don't think we could remove Maven modules in a minor release (e.g. 2.4.0).  However, we could do it in a major release (e.g. 3.0.0).  I'd like to tag and get the release out for a vote today.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1623: ARTEMIS-1488 add 'all' client jar to di...

pgfox
In reply to this post by pgfox
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1623#discussion_r147768895
 
    --- Diff: artemis-distribution/pom.xml ---
    @@ -39,6 +39,11 @@
          <!-- ActiveMQ Artemis artifacts -->
           <dependency>
              <groupId>org.apache.activemq</groupId>
    +         <artifactId>artemis-jms-client-all</artifactId>
    --- End diff --
   
    Cool, as noted I’m happy for this to merge


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1623: ARTEMIS-1488 add 'all' client jar to di...

pgfox
In reply to this post by pgfox
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1623


---