[GitHub] activemq-artemis pull request #1614: NO-JIRA fix parameter name in HTTP exam...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1614: NO-JIRA fix parameter name in HTTP exam...

clebertsuconic-3
GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1614

    NO-JIRA fix parameter name in HTTP example

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis master_work

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1614.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1614
   
----
commit f0824f7de4ff8ea21e3c53ef43e7c9e5208d72ad
Author: Justin Bertram <[hidden email]>
Date:   2017-10-25T14:08:51Z

    NO-JIRA fix parameter name in HTTP example

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1614: Fix a couple of small issues

clebertsuconic-3
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1614#discussion_r146897785
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageConsumerTest.java ---
    @@ -430,6 +430,15 @@ public void testSelectorsWithJMSDeliveryOnQueue() throws Exception {
           }
        }
     
    +   @Test
    --- End diff --
   
    could a timeout be added?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1614: Fix a couple of small issues

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1614#discussion_r146899887
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageConsumerTest.java ---
    @@ -430,6 +430,15 @@ public void testSelectorsWithJMSDeliveryOnQueue() throws Exception {
           }
        }
     
    +   @Test
    --- End diff --
   
    That test wasn't meant to stay in the PR as I just used it to reproduce the intermittent failure.  I've removed it and updated the PR.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1614: Fix a couple of small issues

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1614


---