[GitHub] activemq-artemis pull request #1609: [ARTEMIS-1480]Console purge Queue is br...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1609: [ARTEMIS-1480]Console purge Queue is br...

pgfox
GitHub user shailendra14k opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1609

    [ARTEMIS-1480]Console purge Queue is broken

    https://issues.apache.org/jira/browse/ARTEMIS-1480

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shailendra14k/activemq-artemis ARTEMIS-1480

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1609.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1609
   
----
commit d65d0164dbe3a463b4da1289fa22cfc1a9db00a1
Author: Shailendra Kumar Singh <[hidden email]>
Date:   2017-10-24T19:47:15Z

    [ARTEMIS-1480]Console purge Queue is broken

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1609: [ARTEMIS-1480]Console purge Queue is br...

pgfox
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1609


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1609: [ARTEMIS-1480]Console purge Queue is broken

pgfox
In reply to this post by pgfox
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1609
 
    Thanks!


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1609: [ARTEMIS-1480]Console purge Queue is broken

pgfox
In reply to this post by pgfox
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1609
 
    @jbertram @mtaylor can we check this please almost all actions (delete also) use existing pattern, either there is a fundamental issue with all, (it be good to know under what scenario purge is broken) or this change isn't needed.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1609: [ARTEMIS-1480]Console purge Queue is broken

pgfox
In reply to this post by pgfox
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1609
 
    @jbertram @mtaylor @shailendra14k completely ignore me, didn't notice the method in service simply wasn't implemented and now @shailendra14k implemented it. Sorry.
   
    Nice work @shailendra14k


---