[GitHub] activemq-artemis pull request #1608: Set validated user in all messages

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1608: Set validated user in all messages

pgfox
GitHub user cburlinchon opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1608

    Set validated user in all messages

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cburlinchon/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1608.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1608
   
----
commit 0679ac83cbe38513cc4615d948ba2c97fab85589
Author: Chris Burlinchon <[hidden email]>
Date:   2017-10-24T16:11:19Z

    artemis-server: Move setValidatedUserID to a common codepath

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1608: Set validated user in all messages

pgfox
Github user tabish121 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
 
    There doesn't seem to be a JIRA issue associated with this, nor are there tests, or even text explaining why the change is needed.  Would be good to add those.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1608: ARTEMIS-1479 Set validated user in all message...

pgfox
In reply to this post by pgfox
Github user cburlinchon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
 
    Hi,
    When sending large message I've hit this:
    java.lang.IllegalArgumentException: Missing validated user from the Artemis message
   
    Seems we don't setValidatedUserID when going through the slowPacketHandler in ServerSessionPacketHandler. I've raised a jira, let me know if you think it is a bug. I'll create some tests in meantime


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1608: ARTEMIS-1479 Set validated user in all message...

pgfox
In reply to this post by pgfox
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
 
    @cburlinchon, per my email to the dev list earlier this week, I plan on doing a release soon so if you want this in there please update the PR ASAP.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1608: ARTEMIS-1479 Set validated user in all message...

pgfox
In reply to this post by pgfox
Github user cburlinchon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
 
    To reproduce: run LargeMessageExample.java with populate-validated-user set to true(I've toggled this in artemis-configuration.xsd). It hangs on Receiving message for me


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1608: ARTEMIS-1479 Set validated user in all message...

pgfox
In reply to this post by pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
 
    /me testing.. leave it with me


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1608: ARTEMIS-1479 Set validated user in all message...

pgfox
In reply to this post by pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
 
    @cburlinchon nice one.. thanks a lot.. merging it


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1608: ARTEMIS-1479 Set validated user in all message...

pgfox
In reply to this post by pgfox
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1608
 
    there is an issue on checkstyle.. also you are using a static block on the test...
   
    I have fixed this with checking out a branch.. amending, and I'm merging the fixes as yours just for the sake of being easier than going back and forth comments... take a look though after I merged it.. thanks


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1608: ARTEMIS-1479 Set validated user in all ...

pgfox
In reply to this post by pgfox
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1608


---