[GitHub] activemq-artemis pull request #1606: [ARTEMIS-1477] Removing netty-all depen...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1606: [ARTEMIS-1477] Removing netty-all depen...

pgfox
GitHub user ederign opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1606

    [ARTEMIS-1477] Removing netty-all dependency from jms-client

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ederign/activemq-artemis dep-removal

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1606.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1606
   
----
commit c848bcd9eb6a5b8a91f18c81dc4855b82037a0bf
Author: ederign1 <[hidden email]>
Date:   2017-10-23T16:37:41Z

    [ARTEMIS-1477] Removing netty-all dependency from jms-client

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1606: [ARTEMIS-1477] Removing netty-all dependency f...

pgfox
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1606
 
    - The JIRA title and the commit comment both reference the jms-client, but none of the files changed are directly related to the jms-client.  Any chance you could update these to be more accurate?  
    - Can you provide a quick explanation of why the change is necessary?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1606: [ARTEMIS-1477] Removing netty-all depen...

pgfox
In reply to this post by pgfox
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1606


---