[GitHub] activemq-artemis pull request #1455: ARTEMIS-1335 Update Netty to 4.1.14 - M...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1455: ARTEMIS-1335 Update Netty to 4.1.14 - M...

tabish121-2
GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1455

    ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix

    Fix for MQTT in connect due to deprecated methods bug causing NPE, call new methods and null check ourselves.
   
    Also raised https://github.com/netty/netty/issues/7076 upstream but i guess we will keep this, as the old methods are deprecated anyhow.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1335-FIX

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1455
   
----
commit ea623c963eb738ebc00f60f702058a43c474f931
Author: Michael Andre Pearce <[hidden email]>
Date:   2017-08-10T00:18:00Z

    ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix
   
    Fix for MQTT in connect due to deprecated methods bug causing NPE, call new methods and null check ourselves.
   
    Also raised https://github.com/netty/netty/issues/7076 upstream but i guess we will keep this, as the old methods are deprecated anyhow.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1455: ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix

tabish121-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1455
 
    @clebertsuconic @mtaylor found the problem in MQTT when upgrade of Netty and fixed it, and sorted it. If you could merge/validate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1455: ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix

tabish121-2
In reply to this post by tabish121-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1455
 
    build box still has perm issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1455: ARTEMIS-1335 Update Netty to 4.1.14 - M...

tabish121-2
In reply to this post by tabish121-2
Github user michaelandrepearce closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1455


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1455: ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix

tabish121-2
In reply to this post by tabish121-2
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1455
 
    @michaelandrepearce Thanks for this.  I actually raised the String usage for the APIs with the Netty guys.  That was a couple versions ago, looks like we got caught out during the upgrade.  Cheers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1455: ARTEMIS-1335 Update Netty to 4.1.14 - MQTT fix

tabish121-2
In reply to this post by tabish121-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1455
 
    @mtaylor it would have been fine if weren't for a bug in their code change to keep the deprecated method. Would have been easier to spot if they just removed the method because then would have been compile time. Hey ho. We're now using the new methods :) and we save a byte[] to string to byte[] skip and a jump now so that's good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...