[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

franz1981
GitHub user pgfox opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1453

    minor update to log message in browser command

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pgfox/activemq-artemis log_message_update

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1453.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1453
   
----
commit 2f6e4c5491d95696e0e141e16149c1b88a399698
Author: Pat Fox <[hidden email]>
Date:   2017-08-09T16:28:27Z

    minor update to log message in browse command

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

franz1981
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1453#discussion_r132276032
 
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConsumerThread.java ---
    @@ -124,7 +124,7 @@ public void browse() {
              }
           }
     
    -      System.out.println(threadName + " Consumer thread finished");
    +      System.out.println(threadName + " thread finished");
    --- End diff --
   
    Browser thread finished


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

franz1981
In reply to this post by franz1981
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1453#discussion_r132276246
 
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConsumerThread.java ---
    @@ -115,7 +115,7 @@ public void browse() {
                 finished.countDown();
              }
              if (consumer != null) {
    -            System.out.println(threadName + " Consumed: " + this.getReceived() + " messages");
    +            System.out.println(threadName + " browsed: " + this.getReceived() + " messages");
    --- End diff --
   
    capitalise "Browsed: " to match other capitalisation in other sys outs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

franz1981
In reply to this post by franz1981
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1453#discussion_r132276525
 
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConsumerThread.java ---
    @@ -81,7 +81,7 @@ public void browse() {
              while (enumBrowse.hasMoreElements()) {
                 Message msg = enumBrowse.nextElement();
                 if (msg != null) {
    -               System.out.println(threadName + " Received " + (msg instanceof TextMessage ? ((TextMessage) msg).getText() : msg.getJMSMessageID()));
    +               System.out.println(threadName + " Browsing " + (msg instanceof TextMessage ? ((TextMessage) msg).getText() : msg.getJMSMessageID()));
    --- End diff --
   
    consistency of casing, maybe lowercase Browsing? either that or make others Capitalised.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1453: minor update to log message in browser command

franz1981
In reply to this post by franz1981
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1453
 
    @pgfox can you open a JIRA for this and update the commit message to include it, e.g.
   
    ARTEMIS-XXXX changed log message to state browse/browsing instead of consume/consuming
     
    where xxxx is the jira number.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1453: minor update to log message in browser command

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1453
 
    @michaelandrepearce I was going to merge this with NO-JIRA ammended



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1453: minor update to log message in browser command

franz1981
In reply to this post by franz1981
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1453
 
    @clebertsuconic cool beans. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1453#discussion_r132295056
 
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConsumerThread.java ---
    @@ -81,7 +81,7 @@ public void browse() {
              while (enumBrowse.hasMoreElements()) {
                 Message msg = enumBrowse.nextElement();
                 if (msg != null) {
    -               System.out.println(threadName + " Received " + (msg instanceof TextMessage ? ((TextMessage) msg).getText() : msg.getJMSMessageID()));
    +               System.out.println(threadName + " Browsing " + (msg instanceof TextMessage ? ((TextMessage) msg).getText() : msg.getJMSMessageID()));
    --- End diff --
   
    @pgfox you think you can change that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1453#discussion_r132295112
 
    --- Diff: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConsumerThread.java ---
    @@ -124,7 +124,7 @@ public void browse() {
              }
           }
     
    -      System.out.println(threadName + " Consumer thread finished");
    +      System.out.println(threadName + " thread finished");
    --- End diff --
   
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1453: minor update to log message in browser command

franz1981
In reply to this post by franz1981
Github user pgfox commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1453
 
    @clebertsuconic  @michaelandrepearce  Sure, your suggested changes should be in the pull request now. Thanks
   
   
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1453: minor update to log message in browser ...

franz1981
In reply to this post by franz1981
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1453


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...