[GitHub] activemq-artemis pull request #1452: ARTEMIS-1335 Update Netty to 4.1.14

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1452: ARTEMIS-1335 Update Netty to 4.1.14

tabish121-2
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1452#discussion_r132177518
 
    --- Diff: artemis-journal/src/main/java/io/netty/buffer/UnpooledUnsafeDirectByteBufWrapper.java ---
    @@ -563,7 +564,11 @@ protected SwappedByteBuf newSwappedByteBuf() {
        @Override
        public ByteBuf setZero(int index, int length) {
           if (hasMemoryAddress()) {
    -         UnsafeByteBufUtil.setZero(this, addr(index), index, length);
    +         if (length == 0) {
    --- End diff --
   
    We have to do this as UnsafeByteBufUtil.setZero(this, addr(index), index, length); util method is removed in 4.1.14 this was the underlying util logic.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...