[GitHub] activemq-artemis pull request #1447: ARTEMIS-1328 Improving direct delivery ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1447: ARTEMIS-1328 Improving direct delivery ...

franz1981
GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1447

    ARTEMIS-1328 Improving direct delivery check

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1328

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1447.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1447
   
----
commit 8a90d1bc3de5ad0d941195e7df8dc72e2f03c256
Author: Clebert Suconic <[hidden email]>
Date:   2017-08-08T03:48:29Z

    ARTEMIS-1328 Improving direct delivery check

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1447: ARTEMIS-1328 Improving direct delivery ...

franz1981
Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1447#discussion_r131832623
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java ---
    @@ -664,7 +664,7 @@ public void addTail(final MessageReference ref, final boolean direct) {
                    if (intermediateMessageReferences.isEmpty() && messageReferences.isEmpty() && !pageIterator.hasNext() && !pageSubscription.isPaging()) {
                       // We must block on the executor to ensure any async deliveries have completed or we might get out of order
                       // deliveries
    -                  if (flushExecutor() && flushDeliveriesInTransit()) {
    +                  if (internalFlushExecutor(500, false) && flushDeliveriesInTransit()) {
    --- End diff --
   
    Why 500 why not 100, if the issue was previously it was taking too long surely we want this as small as safely possible?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1447: ARTEMIS-1328 Improving direct delivery ...

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1447#discussion_r131907760
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java ---
    @@ -664,7 +664,7 @@ public void addTail(final MessageReference ref, final boolean direct) {
                    if (intermediateMessageReferences.isEmpty() && messageReferences.isEmpty() && !pageIterator.hasNext() && !pageSubscription.isPaging()) {
                       // We must block on the executor to ensure any async deliveries have completed or we might get out of order
                       // deliveries
    -                  if (flushExecutor() && flushDeliveriesInTransit()) {
    +                  if (internalFlushExecutor(500, false) && flushDeliveriesInTransit()) {
    --- End diff --
   
    I will change this to no wait at all.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1447: ARTEMIS-1328 Improving direct delivery check

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1447
 
    Please.. don't merge this.. I'm changing this around.. will send another message when it's ok.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1447: ARTEMIS-1328 Improving direct delivery check

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1447
 
    this is now ready...
   
    @michaelandrepearce since you've looked.. mind looking again?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1447: ARTEMIS-1328 Improving direct delivery ...

franz1981
In reply to this post by franz1981
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1447


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1447: ARTEMIS-1328 Improving direct delivery check

franz1981
In reply to this post by franz1981
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1447
 
    @clebertsuconic only query i have
   
    was why this change?
    -   public static final int CHECK_QUEUE_SIZE_PERIOD = 100;
    +   public static final int CHECK_QUEUE_SIZE_PERIOD = 1000;



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...