[GitHub] activemq-artemis pull request #1446: Change on top of #1445

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1446: Change on top of #1445

tabish121-2
GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1446

    Change on top of #1445

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1327

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1446.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1446
   
----
commit 68500d32d2c448c4424e7f023a7d1579d5c5d38f
Author: Christopher L. Shannon (cshannon) <[hidden email]>
Date:   2017-08-07T14:49:46Z

    ARTEMIS-1327 - Support checked exceptions in ActiveMQServerPlugin
   
    This will allow plugin writers to use checked exceptions when writing
    plugins

commit 3e2d06a2f2675fbf2cd0a54db767798453f127b3
Author: Clebert Suconic <[hidden email]>
Date:   2017-08-07T17:52:00Z

    This closes #1445

commit 866e77766917383ddc33c45b71ef8785453cc164
Author: Clebert Suconic <[hidden email]>
Date:   2017-08-07T17:57:29Z

    ARTEMIS-1327 changing exception hangling on plugins

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1446: Change on top of #1445

tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1446
 
    @cshannon I "believe" you should treat the exceptions on callPlugins...
   
    The previous change could have consequences in other places where a bugged plugin could also break the server.
   
   
    if this PR is merged #1445 will also be closed as this one is merging yours.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1446: Change on top of #1445

tabish121-2
In reply to this post by tabish121-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1446


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...