[GitHub] activemq-artemis pull request #1442: ARTEMIS-1322 ServerLocator option to ig...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1442: ARTEMIS-1322 ServerLocator option to ig...

franz1981
GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1442

    ARTEMIS-1322 ServerLocator option to ignore topology for load-balancing

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1322

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1442
   
----
commit 8db94c6f3bd1d179ff340b2bb2e57bf2edbee58c
Author: Justin Bertram <[hidden email]>
Date:   2017-08-04T18:22:43Z

    ARTEMIS-1322 ServerLocator option to ignore topology for load-balancing

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1442: ARTEMIS-1322 ServerLocator option to ig...

franz1981
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1442#discussion_r131460692
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/NettySymmetricClusterTest.java ---
    @@ -16,10 +16,79 @@
      */
     package org.apache.activemq.artemis.tests.integration.cluster.distribution;
     
    +import org.apache.activemq.artemis.api.core.client.ActiveMQClient;
    +import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
    +import org.apache.activemq.artemis.api.core.client.ServerLocator;
    +import org.junit.Test;
    +
     public class NettySymmetricClusterTest extends SymmetricClusterTest {
     
        @Override
        protected boolean isNetty() {
           return true;
        }
    +
    +   @Test
    +   public void testConnectionLoadBalancingUsingInitialConnectors() throws Exception {
    +      final String ADDRESS = "queues.testaddress";
    +      final String QUEUE = "queue0";
    +      final String URL = "(tcp://localhost:61616,tcp://localhost:61617)";
    --- End diff --
   
    can you add a test using the URI?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1442: ARTEMIS-1322 ServerLocator option to ig...

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1442#discussion_r131460725
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/NettySymmetricClusterTest.java ---
    @@ -16,10 +16,79 @@
      */
     package org.apache.activemq.artemis.tests.integration.cluster.distribution;
     
    +import org.apache.activemq.artemis.api.core.client.ActiveMQClient;
    +import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
    +import org.apache.activemq.artemis.api.core.client.ServerLocator;
    +import org.junit.Test;
    +
     public class NettySymmetricClusterTest extends SymmetricClusterTest {
     
        @Override
        protected boolean isNetty() {
           return true;
        }
    +
    +   @Test
    +   public void testConnectionLoadBalancingUsingInitialConnectors() throws Exception {
    +      final String ADDRESS = "queues.testaddress";
    +      final String QUEUE = "queue0";
    +      final String URL = "(tcp://localhost:61616,tcp://localhost:61617)";
    --- End diff --
   
    ?useTopologyForLoadBalance=false


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1442: ARTEMIS-1322 ServerLocator option to ig...

franz1981
In reply to this post by franz1981
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1442#discussion_r131461194
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/NettySymmetricClusterTest.java ---
    @@ -16,10 +16,79 @@
      */
     package org.apache.activemq.artemis.tests.integration.cluster.distribution;
     
    +import org.apache.activemq.artemis.api.core.client.ActiveMQClient;
    +import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
    +import org.apache.activemq.artemis.api.core.client.ServerLocator;
    +import org.junit.Test;
    +
     public class NettySymmetricClusterTest extends SymmetricClusterTest {
     
        @Override
        protected boolean isNetty() {
           return true;
        }
    +
    +   @Test
    +   public void testConnectionLoadBalancingUsingInitialConnectors() throws Exception {
    +      final String ADDRESS = "queues.testaddress";
    +      final String QUEUE = "queue0";
    +      final String URL = "(tcp://localhost:61616,tcp://localhost:61617)";
    --- End diff --
   
    The test I added tests both the positive and negative for useTopologyForLoadBalancing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1442: ARTEMIS-1322 ServerLocator option to ig...

franz1981
In reply to this post by franz1981
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1442#discussion_r131461292
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/NettySymmetricClusterTest.java ---
    @@ -16,10 +16,79 @@
      */
     package org.apache.activemq.artemis.tests.integration.cluster.distribution;
     
    +import org.apache.activemq.artemis.api.core.client.ActiveMQClient;
    +import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
    +import org.apache.activemq.artemis.api.core.client.ServerLocator;
    +import org.junit.Test;
    +
     public class NettySymmetricClusterTest extends SymmetricClusterTest {
     
        @Override
        protected boolean isNetty() {
           return true;
        }
    +
    +   @Test
    +   public void testConnectionLoadBalancingUsingInitialConnectors() throws Exception {
    +      final String ADDRESS = "queues.testaddress";
    +      final String QUEUE = "queue0";
    +      final String URL = "(tcp://localhost:61616,tcp://localhost:61617)";
    --- End diff --
   
    I'm not sure what you mean by "a test using the URI."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1442: ARTEMIS-1322 ServerLocator option to ig...

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1442#discussion_r131461672
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/NettySymmetricClusterTest.java ---
    @@ -16,10 +16,79 @@
      */
     package org.apache.activemq.artemis.tests.integration.cluster.distribution;
     
    +import org.apache.activemq.artemis.api.core.client.ActiveMQClient;
    +import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
    +import org.apache.activemq.artemis.api.core.client.ServerLocator;
    +import org.junit.Test;
    +
     public class NettySymmetricClusterTest extends SymmetricClusterTest {
     
        @Override
        protected boolean isNetty() {
           return true;
        }
    +
    +   @Test
    +   public void testConnectionLoadBalancingUsingInitialConnectors() throws Exception {
    +      final String ADDRESS = "queues.testaddress";
    +      final String QUEUE = "queue0";
    +      final String URL = "(tcp://localhost:61616,tcp://localhost:61617)";
    --- End diff --
   
    @jbertram setting the UsetopologForLoadBalancing through a property on the URI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1442: ARTEMIS-1322 ServerLocator option to ig...

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1442#discussion_r131461824
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/cluster/distribution/NettySymmetricClusterTest.java ---
    @@ -16,10 +16,79 @@
      */
     package org.apache.activemq.artemis.tests.integration.cluster.distribution;
     
    +import org.apache.activemq.artemis.api.core.client.ActiveMQClient;
    +import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
    +import org.apache.activemq.artemis.api.core.client.ServerLocator;
    +import org.junit.Test;
    +
     public class NettySymmetricClusterTest extends SymmetricClusterTest {
     
        @Override
        protected boolean isNetty() {
           return true;
        }
    +
    +   @Test
    +   public void testConnectionLoadBalancingUsingInitialConnectors() throws Exception {
    +      final String ADDRESS = "queues.testaddress";
    +      final String QUEUE = "queue0";
    +      final String URL = "(tcp://localhost:61616,tcp://localhost:61617)";
    --- End diff --
   
    @jbertram I'm expecting it to be easier to set this through the URI as a property.. it would be nice to make sure it works.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1442: ARTEMIS-1322 ServerLocator option to ig...

franz1981
In reply to this post by franz1981
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1442


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...