[GitHub] activemq-artemis pull request #1400: ARTEMIS-128 fix - Unable to configure q...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1400: ARTEMIS-128 fix - Unable to configure q...

mtaylor
GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1400

    ARTEMIS-128 fix - Unable to configure queues containing "/" in broker.xml

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1289

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1400.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1400
   
----
commit 25ff4b5e8998c2e77b894cf10fd0930e39f8caf1
Author: Michael Andre Pearce <[hidden email]>
Date:   2017-07-14T07:03:20Z

    ARTEMIS-128 fix for Unable to configure queues containing "/" in broker.xml

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1400: ARTEMIS-1289 Fix: Unable to configure queues c...

mtaylor
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1400
 
    @michaelandrepearce Thanks for this.
   
    Any chance you could make the queue ID unique.
   
    e.g.
   
    ```xml
       <element name="addresses"...
            <xs:unique name="UniqueQueueName">
                <xs:selector xpath="address/*/queue/@name" />
                <xs:field xpath="@name" />
            </xs:unique>
        </element>
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1400: ARTEMIS-1289 Fix: Unable to configure queues c...

mtaylor
In reply to this post by mtaylor
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1400
 
    Actually, you could add this to the core element instead.  That means it would work for the 1.x way of defining queues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1400: ARTEMIS-1289 Fix: Unable to configure queues c...

mtaylor
In reply to this post by mtaylor
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1400
 
    @mtaylor as discussed in IRC, few comments i would have.
   
    - Address is currently xsd:string already (this is just following suit)
   
    - Duplicate declaration is checked anyhow on config load, do we really need a complex schema? as we don't do this on address and the same applies, that it must be unique.
   
    - Queues can be declared in two places it seems according to the xsd, either within an address, or within the queues section, as such an unique field within one element would not capture where it could be defined in two separate places.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1400: ARTEMIS-1289 Fix: Unable to configure queues c...

mtaylor
In reply to this post by mtaylor
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1400
 
    @michaelandrepearce OK I think these are fair points.  I'll go ahead and merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1400: ARTEMIS-1289 Fix: Unable to configure q...

mtaylor
In reply to this post by mtaylor
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1400


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...