[GitHub] activemq-artemis pull request #1395: ARTEMIS-1269 New actor framework

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1395: ARTEMIS-1269 New actor framework

franz1981
GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1395

    ARTEMIS-1269 New actor framework

    This is replacing an executor on ServerSessionPacketHandler
    by a new actor.
   
    This is to avoid creating a new runnable per packet received.
   
    Instead of creating new Runnable, this will use a single static runnable
    and the packet will be send by a message, which will be treated by a listener.
   
    Look at ServerSessionPacketHandler on this commit for more information on how it works.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis actor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1395.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1395
   
----
commit 5077c58120fede761027b11d3d4924a2ef623fdc
Author: Clebert Suconic <[hidden email]>
Date:   2017-07-10T22:03:55Z

    ARTEMIS-1269 New actor framework
   
    This is replacing an executor on ServerSessionPacketHandler
    by a new actor.
   
    This is to avoid creating a new runnable per packet received.
   
    Instead of creating new Runnable, this will use a single static runnable
    and the packet will be send by a message, which will be treated by a listener.
   
    Look at ServerSessionPacketHandler on this commit for more information on how it works.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1395: ARTEMIS-1269 New actor framework

franz1981
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1395
 
    There are a lot of possibilities for this...
   
   
    Example: https://github.com/clebertsuconic/activemq-artemis/commit/116fb580a97514fac2a78598cc970d78717bb23d
   
   
    I will have to figure out what's going on that it's not working.. but I will soon make this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1395: ARTEMIS-1269 New actor framework

franz1981
In reply to this post by franz1981
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1395
 
    don't mean to be a pain, but why don't we use an existing framework, akka/vert.x? instead of making our own framework we will have to maintain?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1395: ARTEMIS-1269 New actor framework

franz1981
In reply to this post by franz1981
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1395
 
    @clebertsuconic I have two comments on this.
   
    Firstly, what is the goal of this patch.  Is the aim to reduce the GC overhead by reusing Runnables?  If so surely this could be done in a simpler fashion just be creating a Re-usable Runnable?
   
    If the idea here is to "create a framework", I have to agree with Michael that we should be looking to reuse something that already exists.  There's quite a lot of movement towards using reactive patterns which is I believe what you are striving for here.  There are a few popular frameworks/libs for Java.  Have you looked at RxJava?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1395: ARTEMIS-1269 New actor framework

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1395
 
    I don't  want to make a framework.  This is just to diminish GC on a few executors.  
   
   
    Instead of creating a new runnable everybtime we pass in the data.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1395: ARTEMIS-1269 Simple Actor

franz1981
In reply to this post by franz1981
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1395


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...