[GitHub] activemq-artemis pull request #1393: NO-JIRA deprecation fixes

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1393: NO-JIRA deprecation fixes

franz1981
GitHub user jdanekrh opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1393

    NO-JIRA deprecation fixes

    This is kind of a followup to #307. I am putting each fix into separate commit for easier review (which is probably not necessary anymore, because the previous PR fixed a lot of what I originally had prepared here too, so there is not much to review).
   
    I am wondering. What is the opinion about using `//noinspection deprecation` magic comment that IntelliJ likes? (It can apply to a single statement, while the annotation form `@SuppressWarnings("deprecation")` cannot.)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdanekrh/activemq-artemis jd_deprecated

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1393
   
----
commit ffae6ef74f89a34a4036f1c0eb4a093f59f0f2e0
Author: Jiri Danek <[hidden email]>
Date:   2016-07-07T14:52:51Z

    PROTOCOL_PROP_NAME

commit bc9a285659aec776b8bfefb1603866f733855a26
Author: Jiri Danek <[hidden email]>
Date:   2016-07-07T14:55:05Z

    ConnectionLifeCycleListener

commit e8136355bcf63d6310bcf13f4615084a7bde259f
Author: Jiri Danek <[hidden email]>
Date:   2017-02-17T17:19:01Z

    GENERIC_IGNORED_FILTER

commit b55240f6cacd030d934a44cfb78d26943721208a
Author: Jiri Danek <[hidden email]>
Date:   2017-02-17T17:23:13Z

    HttpHeaders.Names

commit f40f104cac2592a7ebcc1ae28ef067c0749f09c6
Author: Jiri Danek <[hidden email]>
Date:   2017-02-17T17:23:52Z

    HttpHeaders.Names and similar

commit be55734b28fd490373d66a01de57ad23d996ecd0
Author: Jiri Danek <[hidden email]>
Date:   2017-06-28T12:03:18Z

    LocalEventLoopGroup

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1393: NO-JIRA deprecation fixes

franz1981
Github user jdanekrh commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1393
 
    Same as previous PR, Jenkins failed because of
   
    >Tests in error:
    >  WebServerComponentTest.simpleServer:87 » Bind Address already in use
    >  WebServerComponentTest.testComponentStopBehavior:124 » Bind Address already in...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1393: NO-JIRA deprecation fixes

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1393#discussion_r126493130
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java ---
    @@ -338,7 +338,7 @@ public ClientSession createSession(final boolean xa,
           return createSessionInternal(null, null, xa, autoCommitSends, autoCommitAcks, preAcknowledge, serverLocator.getAckBatchSize());
        }
     
    -   // ConnectionLifeCycleListener implementation --------------------------------------------------
    --- End diff --
   
    where is the deprecation? I see this a fix, but I'm not sure why you're calling this a deprecation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1393: NO-JIRA deprecation fixes

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1393#discussion_r126493567
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java ---
    @@ -300,7 +300,7 @@ public synchronized void start() throws Exception {
           if (useInvm) {
              acceptorType = INVM_ACCEPTOR_TYPE;
              channelClazz = LocalServerChannel.class;
    -         eventLoopGroup = new LocalEventLoopGroup();
    +         eventLoopGroup = new DefaultEventLoopGroup();
    --- End diff --
   
    nice one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1393: NO-JIRA deprecation fixes

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1393#discussion_r126494394
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java ---
    @@ -338,7 +338,7 @@ public ClientSession createSession(final boolean xa,
           return createSessionInternal(null, null, xa, autoCommitSends, autoCommitAcks, preAcknowledge, serverLocator.getAckBatchSize());
        }
     
    -   // ConnectionLifeCycleListener implementation --------------------------------------------------
    --- End diff --
   
    oic


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1393: NO-JIRA deprecation fixes

franz1981
In reply to this post by franz1981
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1393


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1393: NO-JIRA deprecation fixes

franz1981
In reply to this post by franz1981
Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1393#discussion_r126614869
 
    --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java ---
    @@ -300,7 +300,7 @@ public synchronized void start() throws Exception {
           if (useInvm) {
              acceptorType = INVM_ACCEPTOR_TYPE;
              channelClazz = LocalServerChannel.class;
    -         eventLoopGroup = new LocalEventLoopGroup();
    +         eventLoopGroup = new DefaultEventLoopGroup();
    --- End diff --
   
    thanks. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...