[GitHub] activemq-artemis pull request #1290: ARTEMIS-1182: Add / Port in support for...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1290: ARTEMIS-1182: Add / Port in support for...

asfgit
GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1290

    ARTEMIS-1182: Add / Port in support for JNDIReferenceFactory

    and JNDIStorable
   
    * Add clones/copies of these class's from Qpid (though identical to ActiveMQ 5.x also) to support this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1182

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1290
   
----
commit 3575b5d5c725b25a067582a827b6020193371919
Author: Michael Andre Pearce <[hidden email]>
Date:   2017-05-24T16:36:49Z

    ARTEMIS-1182: Add / Port in support for JNDIReferenceFactory and JNDIStorable
   
    Add clones/copies of these class's from Qpid (though identical to ActiveMQ 5.x also)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1290: ARTEMIS-1182: Add / Port in support for JNDIRe...

asfgit
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1290
 
    again build output says success, jenkins icon is orange, meaning success of this build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1290: ARTEMIS-1182: Add / Port in support for JNDIRe...

asfgit
In reply to this post by asfgit
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1290
 
    did a rebuild by force pushing comment change, all seems green.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1290: ARTEMIS-1182: Add / Port in support for...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1290


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1290: ARTEMIS-1182: Add / Port in support for JNDIRe...

asfgit
In reply to this post by asfgit
Github user Spaction commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1290
 
    This still does not work correctly.
    Things need to extend the JNDIStorable object in order for the factory to work.
   
    It would seems the concept of this was with the JNDIBaseStorable(https://activemq.apache.org/maven/apidocs/org/apache/activemq/jndi/JNDIBaseStorable.html) object of ActiveMQ which has 2 subclasses: ActiveMQConnectionFactory, ActiveMQDestination
   
    For this to correctly work i believe the 2 subclasses on Artemis's side needs to extend the JNDIStorable object.



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1290: ARTEMIS-1182: Add / Port in support for JNDIRe...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1290
 
    @Spaction better to talk about this on the dev list? this is an old PR.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1290: ARTEMIS-1182: Add / Port in support for JNDIRe...

asfgit
In reply to this post by asfgit
Github user Spaction commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1290
 
    @clebertsuconic , no idea where that is or really anything about gitHub. I'm not a contributor to this project, just have been stuck trying to migrate from an ActiveMQ instance to an Artemis one and this is my entire reason for being stuck for a week.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1290: ARTEMIS-1182: Add / Port in support for JNDIRe...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1290
 
    @Spaction github is not the place to ask question.. the user's list is for both activemq and activemq-artemis:
   
    http://activemq.apache.org/discussion-forums.html


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1290: ARTEMIS-1182: Add / Port in support for JNDIRe...

asfgit
In reply to this post by asfgit
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1290
 
    I can look at this, I think I know what @spaction is needing. @spaction if I make some changes in a private branch next week would you be able to build and check it solves your issue?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1290: ARTEMIS-1182: Add / Port in support for JNDIRe...

asfgit
In reply to this post by asfgit
Github user Spaction commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1290
 
    @michaelandrepearce  I should be able to at any point next week. Any logging added can also be sent back.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1290: ARTEMIS-1182: Add / Port in support for JNDIRe...

asfgit
In reply to this post by asfgit
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1290
 
    For future reference, instead of commenting on a PR that has been closed for awhile you can use one of the [ActiveMQ mailing lists](http://activemq.apache.org/mailing-lists.html).  The "user" list is probably the one you'd want to use, although the "dev" list would be fine as well.  Either of these can be used by anybody in the community, not just contributors.  Perhaps if you could explain more fully your use-case and your problem someone else in the community could lend a hand.


---