[GitHub] activemq-artemis pull request #1286: Fix missing JSON support

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1286: Fix missing JSON support

franz1981
GitHub user gnodet opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1286

    Fix missing JSON support

    Not to be merged yet, as it's using a SNAPSHOT.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gnodet/activemq-artemis fix-missing-json

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1286.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1286
   
----
commit ae1a947bd4a7882b931a9ca1b7f3ffc83e2b7a40
Author: Guillaume Nodet <[hidden email]>
Date:   2017-05-19T08:01:53Z

    Fix missing JSON support

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1286: Fix missing JSON support

franz1981
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1286
 
    Can there be added a test case that this is fixing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1286: Fix missing JSON support

franz1981
In reply to this post by franz1981
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1286
 
    It's not obvious to me what's actually being fixed here.  Also, if it's not to be merged then you should probably close the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1286: Fix missing JSON support

franz1981
In reply to this post by franz1981
Github user gnodet commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1286
 
    Sorry, I was in vacation last week and haven't had any time to work further on that.
    Artemis does use json in some cases.  The problem is that in OSGi, the json api bundle is deployed, but it can't locate any provider.  I pushed an updated spec to servicemix to fix the problem as it's usually done for this kind of spec bundles:
      https://git1-us-west.apache.org/repos/asf?p=servicemix-specs.git;a=commitdiff;h=9265f72331f26f8374765d4530522d238edeecf2
    The above commit allows finding a json provider inside a bundle deployed in the OSGi framework.
   
    So this commit deploys this new json api bundle and forces the installation of the johnzon provider.
   
    I plan to create a test case to demonstrate the changes i've been working on, i.e. #1284, #1285 and #1286


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1286: Fix missing JSON support

franz1981
In reply to this post by franz1981
Github user gnodet commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1286
 
    Superseded by #1307


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1286: Fix missing JSON support

franz1981
In reply to this post by franz1981
Github user gnodet closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1286


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---