[GitHub] activemq-artemis pull request #1284: Turn management reply messages into tex...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1284: Turn management reply messages into tex...

franz1981
GitHub user gnodet opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1284

    Turn management reply messages into text messages

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gnodet/activemq-artemis mgmt-reply-message

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1284
   
----
commit b011e164d0ec2cf9c793d6551b291a97f537ee3e
Author: Guillaume Nodet <[hidden email]>
Date:   2017-05-19T08:00:32Z

    Turn management reply messages into text messages

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1284: Turn management reply messages into text messa...

franz1981
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1284
 
    whole testsuite is fine...
   
    Either can you create a JIRA, and:
   
   
    ```
    git commit --amend
    ```
   
   
    ^^^ add the JIRA to the commit
   
   
   
    ```
    git push oritin -f <branch-name>
    ```
   
   
    Or I will do this on monday if you don't do this on the weekend.
   
    I can do work on the weekend, but I am a bit lazy now.. if you don't do it earlier than monday I can amend your commit during merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1284: Turn management reply messages into text messa...

franz1981
In reply to this post by franz1981
Github user gnodet commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1284
 
    JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1176



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1284: Turn management reply messages into tex...

franz1981
In reply to this post by franz1981
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1284


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1284: Turn management reply messages into text messa...

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1284
 
    @gnodet we will need to revert this. Management example is broken... we need a better fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---