[GitHub] activemq-artemis pull request #1281: ARTEMIS-1147 Update Hacking Guide Docum...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1281: ARTEMIS-1147 Update Hacking Guide Docum...

tabish121-2
GitHub user bennetelli opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1281

    ARTEMIS-1147 Update Hacking Guide Documentation: IDE Integration

    the IntelliJ import wizard doesn't contain a sentence like:"Select "Import from existing model". This should be changed to "import project from external model" to be conform and the IntelliJ IDEA version should be updated, too.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bennetelli/activemq-artemis ARTEMIS-1174_Update_Hacking_Guide

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1281
   
----
commit 3153d50395085890a9d7108171efc3c1345376cb
Author: Bennet Schulz <[hidden email]>
Date:   2017-05-18T14:04:46Z

    ARTEMIS-1147 Update Hacking Guide Documentation: IDE Integration
   
    the IntelliJ import wizard doesn't contain a sentence like:"Select "Import from existing model". This should be changed to "import project from external model" to be conform and the IntelliJ IDEA version should be updated, too.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1281: ARTEMIS-1147 Update Hacking Guide Documentatio...

tabish121-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1281
 
    You've transposed 4 and 7 in the JIRA reference of your commit message.  It should be ARTEMIS-1174.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1281: ARTEMIS-1147 Update Hacking Guide Documentatio...

tabish121-2
In reply to this post by tabish121-2
Github user bennetelli commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1281
 
    Argh.. So you need to reject it, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1281: ARTEMIS-1147 Update Hacking Guide Documentatio...

tabish121-2
In reply to this post by tabish121-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1281
 
    I won't merge it if it's referencing the wrong JIRA.  However, it's easy to change.  Just rebase interactively, re-word the commit message, and push -f.  The PR will update automatically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1281: ARTEMIS-1147 Update Hacking Guide Documentatio...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1281
 
    @bennetelli I will merge it as it's already done.. but I'm a bit concerned to keep documenting idea specifics.. ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1281: ARTEMIS-1147 Update Hacking Guide Documentatio...

tabish121-2
In reply to this post by tabish121-2
Github user bennetelli commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1281
 
    @clebertsuconic why? do you mean specifics like version numbers or IntelliJ specifics in general?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1281: ARTEMIS-1147 Update Hacking Guide Documentatio...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1281
 
    in general.. it would be better to just send a link on Idea instead of duplicating the steps...
   
   
    it's minor though.. I'm not going to fight about it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1281: ARTEMIS-1147 Update Hacking Guide Documentatio...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1281
 
    Wrong JIRA: it should be artemis-1174 and not 1147...
   
   
    although I could fix it using ./scripts/checkout-PR.sh and ./scripts/merge-branch.sh.. so don't worry about it.. I fixed it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1281: ARTEMIS-1147 Update Hacking Guide Docum...

tabish121-2
In reply to this post by tabish121-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1281


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1281: ARTEMIS-1147 Update Hacking Guide Documentatio...

tabish121-2
In reply to this post by tabish121-2
Github user bennetelli commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1281
 
    @clebertsuconic yep. thx. thought I would have fixed it myself..
   
    the steps I did:
    - git rebase -i HEAD~1
    - change commit message
    - git push --force
   
    what was my failure?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1281: ARTEMIS-1147 Update Hacking Guide Documentatio...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1281
 
    don't know.. perhaps you did on a wrong branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1281: ARTEMIS-1147 Update Hacking Guide Documentatio...

tabish121-2
In reply to this post by tabish121-2
Github user bennetelli commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1281
 
    ok. strange. will check that. thanks for mertging @clebertsuconic ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---