Quantcast

[GitHub] activemq-artemis pull request #1278: ARTEMIS-1129 Fixing tests after client ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1278: ARTEMIS-1129 Fixing tests after client ...

gnodet-2
GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1278

    ARTEMIS-1129 Fixing tests after client all

    Shade is generating a file named dependency-reduced-pom.xml
    and this is being considered with unaproved license.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis shade

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1278
   
----
commit c45fb0e1303b14c14dcdf3ecb40c3691b69b7e2f
Author: Clebert Suconic <[hidden email]>
Date:   2017-05-18T00:31:29Z

    ARTEMIS-1129 Fixing tests after client all
   
    Shade is generating a file named dependency-reduced-pom.xml
    and this is being considered with unaproved license.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1278: ARTEMIS-1129 Fixing tests after client all

gnodet-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1278
 
    @michaelandrepearce Shade is generating a few files at the sub-modules directories (see the changes).
   
   
    this was failing:
    ```
    mvn -Ptests test
    ```
   
   
    I only ran the examples before.. and the build is now broken without this.
   
   
    do you think these changes are ok?
   
    I'm concerned also that the release would generate these files on the source profile. Something to be checked also.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1278: ARTEMIS-1129 Fixing tests after client all

gnodet-2
In reply to this post by gnodet-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1278
 
    @clebertsuconic def agree that it should be git ignore , as it is generated at build time.
   
    are you saying by adding this exclusion in rat list, the tests break, or without adding it it breaks? i am just running the build with the -Ptests profile now, waiting for it to complete locally.
   
    I know there is the setting dependencyReducedPomLocation which allows you to move it to another directory, problem is this breaks any remaining build process and marked buggy in the shade plugin docs so i don't think we should look at that.
   
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1278: ARTEMIS-1129 Fixing tests after client all

gnodet-2
In reply to this post by gnodet-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1278
 
    The testsuite won't work now with that Pom at root. We need to fix the testsuite by either this PR or a better fix.
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1278: ARTEMIS-1129 Fixing tests after client all

gnodet-2
In reply to this post by gnodet-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1278
 
    It's broken because of the rat plugin check.  So it needs the ignore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1278: ARTEMIS-1129 Fixing tests after client all

gnodet-2
In reply to this post by gnodet-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1278
 
    @clebertsuconic I'm happy with this change.
   
    I have a few more tidy up bits, been working on, as have been exploding the jars to check whats copied in and some bits like notice and license and a load of crud from jgroups, whilst still waiting the -Ptest to complete...
   
    shall i raise a pr to your branch or direct to master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1278: ARTEMIS-1129 Fixing tests after client ...

gnodet-2
In reply to this post by gnodet-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1278


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1278: ARTEMIS-1129 Fixing tests after client all

gnodet-2
In reply to this post by gnodet-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1278
 
    @michaelandrepearce just saw your message after I merged it...
   
   
    Send it to master... I needed to merge it so I could run tests again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1278: ARTEMIS-1129 Fixing tests after client all

gnodet-2
In reply to this post by gnodet-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1278
 
    @clebertsuconic just seen this, rebased and re-raised against master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...