[GitHub] activemq-artemis pull request #1276: [ARTEMIS-1171] Improve log readability ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1276: [ARTEMIS-1171] Improve log readability ...

tabish121-2
GitHub user iweiss opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1276

    [ARTEMIS-1171] Improve log readability around clustering

    Issue: https://issues.apache.org/jira/browse/ARTEMIS-1171

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iweiss/activemq-artemis ARTEMIS-1171

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1276
   
----
commit 1c2c5b13a312cc3ddd3e5c8c0c0ef0603b866bf7
Author: Ingo Weiss <[hidden email]>
Date:   2017-05-17T13:38:01Z

    [ARTEMIS-1171] Improve log readability around clustering
   
    Issue: https://issues.apache.org/jira/browse/ARTEMIS-1171

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1276: [ARTEMIS-1171] Improve log readability ...

tabish121-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1276


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1276: [ARTEMIS-1171] Improve log readability around ...

tabish121-2
In reply to this post by tabish121-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1276
 
    I'm a bit concerned about breaking up log statements across multiple lines as it reduces the effectiveness of tools like grep to search for particular bits of logging along with their context.  My recommendation would be to weed out the details in the logging statement that really aren't necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1276: [ARTEMIS-1171] Improve log readability around ...

tabish121-2
In reply to this post by tabish121-2
Github user iweiss commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1276
 
    Although I agree, knowing what is necessary or not make this quite challenging since what is needed for one is not needed for someone else.
   
    My main concern was the cascade of toString() calls that can pile up quite quickly as seen here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1276: [ARTEMIS-1171] Improve log readability around ...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1276
 
    @iweiss this has been reverted as this broke management.
   
    it would need some work if you want it back.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1276: [ARTEMIS-1171] Improve log readability around ...

tabish121-2
In reply to this post by tabish121-2
Github user iweiss commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1276
 
    @clebertsuconic Understood. I will rework it in the coming days. Sorry for the trouble.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---