[GitHub] activemq-artemis pull request #1275: ARTEMIS-1169 - Implement Interceptors f...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1275: ARTEMIS-1169 - Implement Interceptors f...

tabish121-2
GitHub user andytaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1275

    ARTEMIS-1169 - Implement Interceptors for the AMQP protocol

    https://issues.apache.org/jira/browse/ARTEMIS-1169

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andytaylor/activemq-artemis interceptors

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1275.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1275
   
----
commit e21aab49dc2a74b270afd3972aac61a1ed18f2f5
Author: Andy Taylor <[hidden email]>
Date:   2017-05-17T08:28:44Z

    ARTEMIS-1169 - Implement Interceptors for the AMQP protocol
   
    https://issues.apache.org/jira/browse/ARTEMIS-1169

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1275: ARTEMIS-1169 - Implement Interceptors f...

tabish121-2
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1275#discussion_r117053616
 
    --- Diff: examples/features/standard/interceptor-client-amqp/pom.xml ---
    @@ -0,0 +1,122 @@
    +<?xml version='1.0'?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
    +   <modelVersion>4.0.0</modelVersion>
    +
    +   <parent>
    +      <groupId>org.apache.activemq.examples.broker</groupId>
    +      <artifactId>jms-examples</artifactId>
    +      <version>2.2.0-SNAPSHOT</version>
    +   </parent>
    +
    +   <artifactId>interceptor-client-amqp</artifactId>
    +   <packaging>jar</packaging>
    +   <name>ActiveMQ Artemis AMQP Interceptor Example</name>
    +
    +   <properties>
    +      <activemq.basedir>${project.basedir}/../../../..</activemq.basedir>
    +   </properties>
    +
    +   <dependencies>
    +      <dependency>
    +         <groupId>org.apache.activemq</groupId>
    +         <artifactId>artemis-amqp-protocol</artifactId>
    +         <version>${project.version}</version>
    +      </dependency>
    +
    +      <dependency>
    +         <groupId>org.apache.qpid</groupId>
    +         <artifactId>qpid-jms-client</artifactId>
    +         <version>${qpid.jms.version}</version>
    +      </dependency>
    +
    +      <dependency>
    +         <groupId>io.netty</groupId>
    +         <artifactId>netty-all</artifactId>
    +      </dependency>
    +   </dependencies>
    +
    +   <build>
    +      <plugins>
    +         <plugin>
    +            <groupId>org.apache.activemq</groupId>
    +            <artifactId>artemis-maven-plugin</artifactId>
    +            <executions>
    +               <execution>
    +                  <id>create</id>
    +                  <goals>
    +                     <goal>create</goal>
    +                  </goals>
    +                  <configuration>
    +                     <javaOptions>-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=8000</javaOptions>
    --- End diff --
   
    This should be removed as it's preventing the example from running.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1275: ARTEMIS-1169 - Implement Interceptors f...

tabish121-2
In reply to this post by tabish121-2
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1275#discussion_r117053931
 
    --- Diff: examples/features/standard/interceptor-client-amqp/src/main/java/org/apache/activemq/artemis/amqp/example/InterceptorExample.java ---
    @@ -0,0 +1,59 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.amqp.example;
    +
    +import org.apache.qpid.jms.JmsConnectionFactory;
    +
    +import javax.jms.Connection;
    +import javax.jms.Message;
    +import javax.jms.MessageConsumer;
    +import javax.jms.MessageProducer;
    +import javax.jms.Queue;
    +import javax.jms.Session;
    +import javax.jms.TextMessage;
    +
    +/**
    + * A simple example that shows how to implement and use interceptors with ActiveMQ Artemis with the MQTT protocol.
    --- End diff --
   
    Wrong protocol referenced here. Should be AMQP not MQTT.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1275: ARTEMIS-1169 - Implement Interceptors f...

tabish121-2
In reply to this post by tabish121-2
Github user andytaylor commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1275#discussion_r117054442
 
    --- Diff: examples/features/standard/interceptor-client-amqp/src/main/java/org/apache/activemq/artemis/amqp/example/InterceptorExample.java ---
    @@ -0,0 +1,59 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.amqp.example;
    +
    +import org.apache.qpid.jms.JmsConnectionFactory;
    +
    +import javax.jms.Connection;
    +import javax.jms.Message;
    +import javax.jms.MessageConsumer;
    +import javax.jms.MessageProducer;
    +import javax.jms.Queue;
    +import javax.jms.Session;
    +import javax.jms.TextMessage;
    +
    +/**
    + * A simple example that shows how to implement and use interceptors with ActiveMQ Artemis with the MQTT protocol.
    --- End diff --
   
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1275: ARTEMIS-1169 - Implement Interceptors for the ...

tabish121-2
In reply to this post by tabish121-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1275
 
    The example reports SUCCESS, but it actually fails. It's looking for the property "newSimpleAmqpInterceptor" which should be set by the interceptor, but the interceptor just prints the value of the "SimpleAmqpInterceptor" property.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1275: ARTEMIS-1169 - Implement Interceptors for the ...

tabish121-2
In reply to this post by tabish121-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1275
 
    The PR check passes, but 'mvn -Prelease install' due to checkstyle violations in the new example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1275: ARTEMIS-1169 - Implement Interceptors for the ...

tabish121-2
In reply to this post by tabish121-2
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1275
 
    fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1275: ARTEMIS-1169 - Implement Interceptors f...

tabish121-2
In reply to this post by tabish121-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1275


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---