Quantcast

[GitHub] activemq-artemis pull request #1271: ARTEMIS-1164: NameNotFoundException jav...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1271: ARTEMIS-1164: NameNotFoundException jav...

gnodet-2
GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1271

    ARTEMIS-1164: NameNotFoundException java.naming.provider.url to set url via jndi

    Support setting PROVIDER_URL on initial context to create default connection factories.
   
    Added additional test scenarios, and updated ActiveMQInitialContextFactory to account for these.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1164

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1271.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1271
   
----
commit a00f013f6fc569e01626814a070ef9d6be3f5a1d
Author: Michael Andre Pearce <[hidden email]>
Date:   2017-05-15T16:23:52Z

    ARTEMIS-1164: NameNotFoundException when using java.naming.provider.url to set url via jndi
   
    Support setting PROVIDER_URL on initial context to create default connection factories.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1271: ARTEMIS-1164: NameNotFoundException java.namin...

gnodet-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1271
 
    @jbertram could you merge this one if happy please, sorry about that had my head in code this evening adding the extra test cases after you pointed me to the existing ones, which added a few extra scenarios should be handled better, and refactoring to make it cleaner, to notice your comment in time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1271: ARTEMIS-1164: NameNotFoundException java.namin...

gnodet-2
In reply to this post by gnodet-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1271
 
    rebased, after https://github.com/apache/activemq-artemis/pull/1269 merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1271: ARTEMIS-1164: NameNotFoundException java.namin...

gnodet-2
In reply to this post by gnodet-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1271
 
    @jbertram nudge :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1271: ARTEMIS-1164: NameNotFoundException jav...

gnodet-2
In reply to this post by gnodet-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1271


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1271: ARTEMIS-1164: NameNotFoundException java.namin...

gnodet-2
In reply to this post by gnodet-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1271
 
    @jbertram thanks :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...