Quantcast

[GitHub] activemq-artemis pull request #1270: ARTEMIS-1164: NameNotFoundException jav...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1270: ARTEMIS-1164: NameNotFoundException jav...

gnodet-2
GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1270

    ARTEMIS-1164: NameNotFoundException java.naming.provider.url to set url via jndi

    Support setting PROVIDER_URL on initial context to create default connection factories. To match documentation https://activemq.apache.org/artemis/docs/2.0.0/using-jms.html, and also behaviour that existed in ActiveMQ 5.x

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-1164

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1270.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1270
   
----
commit 7f1885563979522302f217184c8e5f8014acdf82
Author: Michael Andre Pearce <[hidden email]>
Date:   2017-05-15T16:23:52Z

    ARTEMIS-1164: NameNotFoundException when using java.naming.provider.url to set url via jndi
   
    Support setting PROVIDER_URL on initial context to create default connection factories.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1270: ARTEMIS-1164: NameNotFoundException java.namin...

gnodet-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1270
 
    Can you add your tests to org.apache.activemq.artemis.tests.integration.jms.SimpleJNDIClientTest rather than creating a new test class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1270: ARTEMIS-1164: NameNotFoundException java.namin...

gnodet-2
In reply to this post by gnodet-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1270
 
    I went ahead and made the changes on merge. I'm not sure if this will get closed automatically or not. If not, please close it manually. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1270: ARTEMIS-1164: NameNotFoundException jav...

gnodet-2
In reply to this post by gnodet-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1270


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1270: ARTEMIS-1164: NameNotFoundException java.namin...

gnodet-2
In reply to this post by gnodet-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1270
 
    @jbertram I was actually changing quite a bit still :( can you hold off merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1270: ARTEMIS-1164: NameNotFoundException java.namin...

gnodet-2
In reply to this post by gnodet-2
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1270
 
    i see you merged, ill open a new pr, with the changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...