[GitHub] activemq-artemis pull request #1269: Refactory to polimorphic creation conne...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1269: Refactory to polimorphic creation conne...

tabish121-2
GitHub user klausboeing opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1269

    Refactory  to polimorphic creation connection factory.

    Small refactoring to make the code simpler and easier to maintain.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/klausboeing/activemq-artemis refactory-client

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1269
   
----
commit 5d62ca789b8c49234067b57cea3d245ee3b8bf1e
Author: klausboeing <[hidden email]>
Date:   2017-05-13T16:12:07Z

    Refactory  to polimorphic creation connection factory.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1269: Refactory to polimorphic creation connection f...

tabish121-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1269
 
    Couple of things...
   
    - I think this warrants a JIRA. Please open a JIRA at https://issues.apache.org/jira/browse/ARTEMIS with a summary of the issue. Then reference the JIRA in your commit message as described in the [Hacking Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/code.md#commitMessageDetails).
    - The PR build failed because you have not added @Overrides to the proper methods. See [the Maven log](https://builds.apache.org/job/ActiveMQ-Artemis-PR-Build/2993/console) of the PR build for more details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1269: Refactory to polimorphic creation connection f...

tabish121-2
In reply to this post by tabish121-2
Github user klausboeing commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1269
 
    @jbertram I made the adjustments as needed.
   
    How will the ARTEMIS-1163 ticket be processed?
   
    Thanks for listening.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1269: Refactory to polimorphic creation conne...

tabish121-2
In reply to this post by tabish121-2
Github user klausboeing closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1269


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1269: Refactory to polimorphic creation conne...

tabish121-2
In reply to this post by tabish121-2
GitHub user klausboeing reopened a pull request:

    https://github.com/apache/activemq-artemis/pull/1269

    Refactory  to polimorphic creation connection factory.

    Small refactoring to make the code simpler and easier to maintain.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/klausboeing/activemq-artemis refactory-client

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1269
   
----
commit 5d62ca789b8c49234067b57cea3d245ee3b8bf1e
Author: klausboeing <[hidden email]>
Date:   2017-05-13T16:12:07Z

    Refactory  to polimorphic creation connection factory.

commit e0a466d334c16a755a0746546ae78275b88cf87a
Author: klausboeing <[hidden email]>
Date:   2017-05-13T18:53:54Z

    ARTEMIS-1163 Refactory  to polimorphic  connectionfactory creation
   
    Move logic to create a connectionfactory from the ActiveMQJMSClient class to the JMSFactoryType enum to eliminate conditional logic in favor of polymorphism.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1269: Refactory to polimorphic creation conne...

tabish121-2
In reply to this post by tabish121-2
Github user klausboeing closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1269


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1269: Refactory to polimorphic creation conne...

tabish121-2
In reply to this post by tabish121-2
GitHub user klausboeing reopened a pull request:

    https://github.com/apache/activemq-artemis/pull/1269

    Refactory  to polimorphic creation connection factory.

    Small refactoring to make the code simpler and easier to maintain.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/klausboeing/activemq-artemis refactory-client

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1269.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1269
   
----
commit 5d62ca789b8c49234067b57cea3d245ee3b8bf1e
Author: klausboeing <[hidden email]>
Date:   2017-05-13T16:12:07Z

    Refactory  to polimorphic creation connection factory.

commit e0a466d334c16a755a0746546ae78275b88cf87a
Author: klausboeing <[hidden email]>
Date:   2017-05-13T18:53:54Z

    ARTEMIS-1163 Refactory  to polimorphic  connectionfactory creation
   
    Move logic to create a connectionfactory from the ActiveMQJMSClient class to the JMSFactoryType enum to eliminate conditional logic in favor of polymorphism.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1269: ARTEMIS-1163 Refactory to polimorphic creation...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1269
 
    Nice PR though.   Just need to make sure checkstyke is passing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1269: ARTEMIS-1163 Refactory to polimorphic creation...

tabish121-2
In reply to this post by tabish121-2
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1269
 
    @klausboeing, I'm not exactly sure what you're asking. Once the PR is merged I'll close the JIRA.
   
    At this point you need to squash the two commits together into a single commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1269: ARTEMIS-1163 Refactory to polimorphic creation...

tabish121-2
In reply to this post by tabish121-2
Github user klausboeing commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1269
 
    @jbertram Exactly this point I would like to know. Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1269: ARTEMIS-1163 Refactory to polimorphic creation...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1269
 
    YOu have a bit of a mess on your PR right now. you could ammend all your committs into one.. You have the initial one, then a rever, another revert (that I had some trouble rebasing)... that is.. a mess..
   
   
    I could figure out how to fix it.. I will run some tests and merge it..
   
   
    Tip: git rebase -i HEAD~4
   
    git push origin <branch-name> -f


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1269: ARTEMIS-1163 Refactory to polimorphic c...

tabish121-2
In reply to this post by tabish121-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1269


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---