[GitHub] activemq-artemis pull request #1221: ARTEMIS-1127 Match remote Sender and Re...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1221: ARTEMIS-1127 Match remote Sender and Re...

tabish121-2
GitHub user tabish121 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1221

    ARTEMIS-1127 Match remote Sender and Receiver settle modes

    On link attach we currently default out SenderSettleMode to MIXED which
    while legal doesn't truly reflect what the client asked for. We instead
    now update the link to reflect the mode requested by the client
   
    Also add some tests to ensure that we always return the
    ReceiverSettleMode as FIRST since we don't support SECOND.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1127

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1221
   
----
commit 57a189614a98347a9d17df13ec373551dde63729
Author: Timothy Bish <[hidden email]>
Date:   2017-04-21T18:22:09Z

    ARTEMIS-1127 Match remote Sender and Receiver settle modes
   
    On link attach we currently default out SenderSettleMode to MIXED which
    while legal doesn't truly reflect what the client asked for. We instead
    now update the link to reflect the mode requested by the client
   
    Also add some tests to ensure that we always return the
    ReceiverSettleMode as FIRST since we don't support SECOND.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1221: ARTEMIS-1127 Match remote Sender and Re...

tabish121-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1221


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---