[GitHub] activemq-artemis pull request #1220: Removes deprecated use and raw types

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1220: Removes deprecated use and raw types

franz1981
GitHub user zregvart opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1220

    Removes deprecated use and raw types

    This cleans up the Netty implementation by replacing deprecated usage
    and adds type parameters to raw types used.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zregvart/activemq-artemis netty-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1220
   
----
commit 992115cc31bcaab2e830b061729417e5f638930f
Author: Zoran Regvart <[hidden email]>
Date:   2017-04-21T11:40:24Z

    Removes deprecated use and raw types
   
    This cleans up the Netty implementation by replacing deprecated usage
    and adds type parameters to raw types used.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1220: Removes deprecated use and raw types

franz1981
Github user zregvart closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1220


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
GitHub user zregvart reopened a pull request:

    https://github.com/apache/activemq-artemis/pull/1220

    Removes deprecated use and raw types

    This cleans up the Netty implementation by replacing deprecated usage
    and adds type parameters to raw types used.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zregvart/activemq-artemis netty-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1220
   
----
commit 992115cc31bcaab2e830b061729417e5f638930f
Author: Zoran Regvart <[hidden email]>
Date:   2017-04-21T11:40:24Z

    Removes deprecated use and raw types
   
    This cleans up the Netty implementation by replacing deprecated usage
    and adds type parameters to raw types used.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
Github user zregvart commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1220
 
    I'm not having any luck with the CI build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
Github user zregvart closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1220


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
GitHub user zregvart reopened a pull request:

    https://github.com/apache/activemq-artemis/pull/1220

    Removes deprecated use and raw types

    This cleans up the Netty implementation by replacing deprecated usage
    and adds type parameters to raw types used.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zregvart/activemq-artemis netty-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1220
   
----
commit 992115cc31bcaab2e830b061729417e5f638930f
Author: Zoran Regvart <[hidden email]>
Date:   2017-04-21T11:40:24Z

    Removes deprecated use and raw types
   
    This cleans up the Netty implementation by replacing deprecated usage
    and adds type parameters to raw types used.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1220
 
    I ran the PR build locally (i.e. 'mvn -Pfast-tests -Pextra-tests test'). It's hanging on NettyConnectorTest.testStartStop which works on the master branch. It looks like your change broke something.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
Github user zregvart commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1220#discussion_r112814879
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/SharedEventLoopGroup.java ---
    @@ -47,15 +47,19 @@ private SharedEventLoopGroup(EventLoopGroup eventLoopGroup) {
     
        public static synchronized void forceShutdown() {
           if (instance != null) {
    -         instance.shutdown();
    +         try {
    +            instance.shutdownGracefully(100, 3000, TimeUnit.MILLISECONDS).await();
    --- End diff --
   
    Could it be this that hung?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1220#discussion_r112816486
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/SharedEventLoopGroup.java ---
    @@ -47,15 +47,19 @@ private SharedEventLoopGroup(EventLoopGroup eventLoopGroup) {
     
        public static synchronized void forceShutdown() {
           if (instance != null) {
    -         instance.shutdown();
    +         try {
    +            instance.shutdownGracefully(100, 3000, TimeUnit.MILLISECONDS).await();
    --- End diff --
   
    Possibly. You'll need to run the tests and make a determination.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1220
 
    What's the status on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
Github user zregvart commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1220
 
    @jbertram sorry didn't find the time to look into this, will take another look towards the middle or end of the week, thank you for your patience 👍


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
Github user zregvart commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1220
 
    trying to trigger CI


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
Github user zregvart closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1220


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
GitHub user zregvart reopened a pull request:

    https://github.com/apache/activemq-artemis/pull/1220

    Removes deprecated use and raw types

    This cleans up the Netty implementation by replacing deprecated usage
    and adds type parameters to raw types used.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zregvart/activemq-artemis netty-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1220
   
----
commit 6db0c50272dcc83f73fc065e6e0a59981c9875bb
Author: Zoran Regvart <[hidden email]>
Date:   2017-04-21T11:40:24Z

    Removes deprecated use and raw types
   
    This cleans up the Netty implementation by replacing deprecated usage
    and adds type parameters to raw types used.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
Github user zregvart commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1220
 
    @jbertram I finally got this to work, would you mind having another look? Thanks 👍


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1220


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1220: Removes deprecated use and raw types

franz1981
In reply to this post by franz1981
Github user zregvart commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1220
 
    Thanks 👍


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...