[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

asfgit
GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1215

    ARTEMIS-1093 Full qualified queue name support

    Broker should support full qualified queue names (FQQN)
    as well as bare queue names. This means when clients access
    to a queue they have two equivalent ways to do so. One way
    is by queue names and the other is by FQQN (i.e. address::qname)
    names. Currently only receiving is supported.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis master_more_fqqn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1215
   
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1215
 
    @clebertsuconic @mtaylor This is a resubmit of FQQN PR, with all tests fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1215
 
    guys please hold on this commit, I found some garbage files need to remove.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

asfgit
In reply to this post by asfgit
Github user tabish121 commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1215#discussion_r112475520
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java ---
    @@ -53,38 +56,61 @@
     import org.apache.qpid.proton.engine.Sender;
     import org.jgroups.util.UUID;
     import org.junit.Test;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Parameterized;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
     /**
      * Test basic send and receive scenarios using only AMQP sender and receiver links.
      */
    +@RunWith(Parameterized.class)
    --- End diff --
   
    This seems like an unnecessary change to this test.  The intent here is to test basic AMQP protocol support not to test the FQQN support in the broker which it appears is already done in the ProtonFullQualifiedNameTest.  I'd prefer if we could keep tests targeted and not try and make them test the entirety of the broker features in one monolithic test case as that makes it harder to maintain.  If you changed this one why didn't you change every single AMQP test in the same fashion?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1215#discussion_r112476953
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java ---
    @@ -53,38 +56,61 @@
     import org.apache.qpid.proton.engine.Sender;
     import org.jgroups.util.UUID;
     import org.junit.Test;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Parameterized;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
     /**
      * Test basic send and receive scenarios using only AMQP sender and receiver links.
      */
    +@RunWith(Parameterized.class)
    --- End diff --
   
    @tabish121 ok, I'll remove it to keep it simple.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1215
 
    OK, I removed the garbage files and reverted AmqpSendReceiveTest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1215
 
    Please.  While the whole testsuite ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1215
 
    There might be a problem with Jenkins machine, the failure relates to 'memory allocation'. Not related to my PR.
    @clebertsuconic I ran the whole test suite on my local machine, there are few test failures but none of them related to my PR. They failed both with and without my PR. (I'll investigate those failures further when I got time).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1215
 
    @mtaylor I will let you merge this.. but this PR is +1 from me..
   
    nice job @gaohoward


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1215
 
    @gaohoward actually, the example managmeent is broken after this. Can you look please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1215
 
    @clebertsuconic sure I'll take care of it. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1215
 
    @clebertsuconic @mtaylor turns out I compared a String address with SimpleString, which always return false. Fixed that and added a simple test.
    Jenkins for the moment seems down, I'll kick off a build when it's back.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1215: ARTEMIS-1093 Full qualified queue name support

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1215
 
    Jenkins looking good. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1215#discussion_r112842725
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/util/FQQN.java ---
    @@ -0,0 +1,31 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.tests.util;
    +
    +import org.apache.activemq.artemis.api.core.SimpleString;
    +import org.apache.activemq.artemis.utils.CompositeAddress;
    +
    +public final class FQQN {
    +
    --- End diff --
   
    Can you remove this class, and move these two methods towards CompositeAddress


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1215


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1215#discussion_r112843427
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/util/FQQN.java ---
    @@ -0,0 +1,31 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.tests.util;
    +
    +import org.apache.activemq.artemis.api.core.SimpleString;
    +import org.apache.activemq.artemis.utils.CompositeAddress;
    +
    +public final class FQQN {
    +
    --- End diff --
   
    Actually, I already did while merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1215: ARTEMIS-1093 Full qualified queue name ...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1215#discussion_r112863550
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/util/FQQN.java ---
    @@ -0,0 +1,31 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements. See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.activemq.artemis.tests.util;
    +
    +import org.apache.activemq.artemis.api.core.SimpleString;
    +import org.apache.activemq.artemis.utils.CompositeAddress;
    +
    +public final class FQQN {
    +
    --- End diff --
   
    @clebertsuconic  Thanks. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...