Quantcast

[GitHub] activemq-artemis pull request #1204: ARTEMIS-1112: don't block live activati...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1204: ARTEMIS-1112: don't block live activati...

franz1981
GitHub user bgutjahr opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1204

    ARTEMIS-1112: don't block live activation if another live server is running

    Instead of going directly into backup mode within the shared-store
    live activation, we just change the HA-policy to slave and return
    to the caller - ActiveMQServerImpl.internalStart().
    The caller will then handle the backup activation as usual
    in a separate thread, such that EmbeddedJMS.start() can return.
    
    modified:   artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedStoreLiveActivation.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bgutjahr/activemq-artemis master-as-backup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1204
   
----
commit b3e39e3c2038de9c94251525a21f216d82cd0958
Author: Bernd Gutjahr <[hidden email]>
Date:   2017-04-13T13:01:36Z

    ARTEMIS-1112: don't block live activation if another live server is running
   
    Instead of going directly into backup mode within the shared-store
    live activation, we just change the HA-policy to slave and return
    to the caller - ActiveMQServerImpl.internalStart().
    The caller will then handle the backup activation as usual
    in a separate thread, such that EmbeddedJMS.start() can return.
    
    modified:   artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/SharedStoreLiveActivation.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1204: ARTEMIS-1112: don't block live activation if a...

franz1981
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1204
 
    Can you add a test to your commit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1204: ARTEMIS-1112: don't block live activation if a...

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1204
 
    also, this kind of thing it first needs a master, then a cherrypick into 1.x
   
   
    or if you exceptionally fixed into 1.x for a good reason, then you need to push the change on master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1204: ARTEMIS-1112: don't block live activation if a...

franz1981
In reply to this post by franz1981
Github user bgutjahr commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1204
 
    OK, I'll push my change on master. The reason why I did it for 1.x is that we have a product which is currently using 1.5.4 and we did not yet plan to switch 2.0 so far. I have not even started to look into what implications a switch to 2.0 would have for us.
   
    I can try to write a test. Can someone give me some hints, e.g. where to put it, what other test I could use as a model?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1204: ARTEMIS-1112: don't block live activation if a...

franz1981
In reply to this post by franz1981
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1204
 
    For an example of how the test might look take a peek at org.apache.activemq.artemis.tests.integration.SimpleTest or org.apache.activemq.artemis.tests.integration.cluster.failover.SharedStoreBackupTest. You can put the resulting test in org.apache.activemq.artemis.tests.integration.cluster.failover.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1204: ARTEMIS-1112: don't block live activation if a...

franz1981
In reply to this post by franz1981
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1204
 
    You may use smokeTests as well. we only have one now but we can expand.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1204: ARTEMIS-1112: don't block live activation if a...

franz1981
In reply to this post by franz1981
Github user bgutjahr commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1204
 
    I have added an integration test. Jenkins build failed, but I don't see why.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...