Quantcast

[GitHub] activemq-artemis pull request #1194: ARTEMIS-1108: Removed AIOFileLockManage...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1194: ARTEMIS-1108: Removed AIOFileLockManage...

RomanIsko
GitHub user bgutjahr opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1194

    ARTEMIS-1108: Removed AIOFileLockManager

    AIOFileLockManager doesn't work on NFS-mounted share store directories. Since the GFS2 bug https://bugzilla.redhat.com/show_bug.cgi?id=678585 has been fixed end of 2011, the class AIOFileLockManager is no longer needed and I have removed it.
   
    deleted:    artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/AIOFileLockNodeManager.java
    modified:   artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
    modified:   artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ColocatedActiveMQServer.java
    modified:   tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/FileLockTest.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bgutjahr/activemq-artemis filelockfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1194.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1194
   
----
commit d1d9a7764fc8e51c6453900bf4aa4654c0531def
Author: Bernd Gutjahr <[hidden email]>
Date:   2017-04-11T07:47:11Z

    ARTEMIS-1108: Removed AIOFileLockManager
   
    AIOFileLockManager doesn't work on NFS-mounted share store directories. Since the GFS2 bug https://bugzilla.redhat.com/show_bug.cgi?id=678585 has been fixed end of 2011, the class AIOFileLockManager is no longer needed and I have removed it.
   
    deleted:    artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/AIOFileLockNodeManager.java
    modified:   artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
    modified:   artemis-server/src/test/java/org/apache/activemq/artemis/tests/util/ColocatedActiveMQServer.java
    modified:   tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/server/impl/FileLockTest.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1194: ARTEMIS-1108: Removed AIOFileLockManager

RomanIsko
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1194
 
    Have you actually tested this change on a GFS2 file-system to ensure fail-over happens as expected?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1194: ARTEMIS-1108: Removed AIOFileLockManager

RomanIsko
In reply to this post by RomanIsko
Github user bgutjahr commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1194
 
    No, I didn't actually test it with GFS2. I just based my change on the fact that the GFS2 bug 678585 has been closed as fixed in 2011, and that I using fcntl is typically recommended. Also it looks like NIO uses fcntl, so I would guess that NIO also didn't work with that GFS2 bug. I can try setting up a GFS2 file-system, but I haven't done it before. This would probably take at least a few days, maybe next week.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1194: ARTEMIS-1108: Removed AIOFileLockManager

RomanIsko
In reply to this post by RomanIsko
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1194
 
    No, NIO wouldn't work with GFS2, we were recommending libaio with GFS2.
   
    I would need to verify this works with GFS2 before we can merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1194: ARTEMIS-1108: Removed AIOFileLockManager

RomanIsko
In reply to this post by RomanIsko
Github user bgutjahr commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1194
 
    I have now setup a GFS2 file system, shared between 2 nodes (with CentOS 6.9, gfs2-utils-3.0.12.1, most according to this description: https://hungred.com/how-to/setup-gfs2-gfs-linux-centos/). HA failover from life to backup server worked well multiple times.
    BTW: it also worked with NIO. Initially NIO was used because libartemis-native-64.so version 1.5.4, which I got from mvnrepository.com, has a dependency to glibc-1.14. But CentOS 6 has glibc-1.12, so the library wasn't loaded and Artemis fell back to NIO. I had to compile the library on CentOS 6 to get AIO working.
    Nevertheless, this was just a quick test that the failover worked. I have no idea how/where the GFS2 bug affected Artemis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1194: ARTEMIS-1108: Removed AIOFileLockManager

RomanIsko
In reply to this post by RomanIsko
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1194
 
    @bgutjahr I'm happy to let this locker go if locking works now.
   
    This was a hack to go around the GFS2 bug. Now it can go freely 👍


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1194: ARTEMIS-1108: Removed AIOFileLockManage...

RomanIsko
In reply to this post by RomanIsko
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1194


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...