Quantcast

[GitHub] activemq-artemis pull request #1172: ARTEMIS-1093 Full qualified queue name ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
23 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1172: ARTEMIS-1093 Full qualified queue name ...

RomanIsko
GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1172

    ARTEMIS-1093 Full qualified queue name support

    Broker should support full qualified queue names (FQQN)
    as well as bare queue names. This means when clients access
    to a queue they have two equivalent ways to do so. One way
    is by queue names and the other is by FQQN (i.e. address::qname)
    names. When accessing a queue by its bare name, it is required
    that the name should be unique across all addresses.
    Otherwise a warning is given and client should use FQQN instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis master_fqn

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1172
   
----
commit 9085d5a6b6ae0220e09972f3a3cff3aea06e510c
Author: Howard Gao <[hidden email]>
Date:   2017-04-05T03:21:16Z

    ARTEMIS-1093 Full qualified queue name support
   
    Broker should support full qualified queue names (FQQN)
    as well as bare queue names. This means when clients access
    to a queue they have two equivalent ways to do so. One way
    is by queue names and the other is by FQQN (i.e. address::qname)
    names. When accessing a queue by its bare name, it is required
    that the name should be unique across all addresses.
    Otherwise a warning is given and client should use FQQN instead.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @mtaylor Martyn can you review this? Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @gaohoward Howard, I am a bit confused by your commit message.  Since the new addressing change, clients should now refer to an ANYCAST address name, not the queue name.  Do this commit change the behaviour here or was OpenWire still referring to the queue name?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    Yes OpenWire still referring to the queue name, in JMS terms. Not sure what you meant by "ANYCAST address name". My understanding is that when you send messages you send to an address of anycast and/or multicast route type, is that correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @gaohoward  for something like this you should have talked to us through a DISCUSS thread, or talked about some design first...
   
    There's WildcardConfiguration already...
   
   
    this is a big change, and I don't like it much.. it adds a complext piece of a referenceCounting on this Key, plus some concatenations to lookup for Addresses...
   
    I'm really concerned about letting this change go in...
   
   
    Can't we have a simpler change.. perhaps use the WildcardAddressManager in any way? what it is needed that is not covered by that already?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @clebertsuconic This is already in user's manual, I thought it just missed the implementation. But anyway I couldn't send out a discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @clebertsuconic fyi
    https://github.com/apache/activemq-artemis/blob/master/docs/user-manual/en/address-model.md#fully-qualified-queue-names


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @gaohoward @clebertsuconic Just to clarify Clebert is referring to the implementation not the feature.  The feature is required.
   
    @gaohoward is it possible to use the existing SimpleAddressManager or WildcardAddressManager and just add a new binding for "address::foo" -> QueueBindingImpl(name="foo", address="address") ?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @mtaylor  is it possible to use the existing SimpleAddressManager or WildcardAddressManager and just add a new binding for "address::foo" -> QueueBindingImpl(name="foo", address="address") ?
   
    Let me think about it...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @gaohoward Could you split this into two patches.  The consume should be pretty easy.  If the subscribe packet contains a FQQN then parse the address, then lookup the queue.  The send is harder but we can resolve that later.  Cheers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @mtaylor ok. BTW I didn't change the send part at all. My thought is that sending is always targeted to an address, not a queue, so it doesn't make sense to reference an address by FQQN.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @gaohoward another reason to simplify the patch then. Make it simple please!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @mtaylor @clebertsuconic guys thanks for the comments/suggestions. I'll try to simplify if it is possible. I think I'd better send out a discussion giving the details of how it is implemented before I change any code. Sorry for not having done it first, I've had too much assumptions. :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @gaohoward you don't have to open a discuss for every simple fix you're going to make..
   
    But the one you had here was certainly not simple.
   
    If you simplify the logic then you don't need one probably


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @clebertsuconic Just sent a discussion to dev list. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @gaohoward From a end users point of view, I'd like at some point to be able to send direct to a queue.  I thought you'd already done the work for this in this patch.  If not, then the really simple thing to do here is intercept the consume packet, parse the FQQN and look up the queue.  It should be straight forward since the queue name is part of the FQQN, then just check that the first part of the FQQN (the address) matches the address on the queue.  You'll also need to ensure that this works with auto-create-queues and auto-create-addresses.
   
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @mtaylor I update the PR, pls review again.
    About sending direct to a queue, I think we can do it in another task. According to current design, messages are meant for address as always, then postoffice routes the messages to a target queue, based on the routing type of the address.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @gaohoward Yes, just do it on consume for now.  We'll sort out the send later.  Could you just ensure that this is reflected in the docs.  I.e. support for AMQP, JMS, OpenWire on consume only.  Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @mtaylor ok will do.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1172: ARTEMIS-1093 Full qualified queue name support

RomanIsko
In reply to this post by RomanIsko
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1172
 
    @mtaylor done updating doc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
12
Loading...