[GitHub] activemq-artemis pull request #1150: NO-JIRA Fixing testReceiveWildcardTopic...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1150: NO-JIRA Fixing testReceiveWildcardTopic...

asfgit
GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1150

    NO-JIRA Fixing testReceiveWildcardTopicMatchDoubleWildcard

    Fixing JmsTopicWildcardSendReceiveTest::testReceiveWildcardTopicMatchDoubleWildcard
   
    Accordingly to bisect, this test was broken at 21b64b3e4f4fc6dbeaa30ce610ecefa15110100a

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis openwire

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1150
   
----
commit d49a34c8252c78c01bbeb8b736c50e73267c9e78
Author: Clebert Suconic <[hidden email]>
Date:   2017-03-29T02:11:57Z

    NO-JIRA Fixing testReceiveWildcardTopicMatchDoubleWildcard
   
    Fixing JmsTopicWildcardSendReceiveTest::testReceiveWildcardTopicMatchDoubleWildcard
   
    Accordingly to bisect, this test was broken at 21b64b3e4f4fc6dbeaa30ce610ecefa15110100a

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1150
 
    @dejanb I'm fixing a test here, accordingly to a bisect it was broken at 21b64b3...
   
    Your change was correct.. so I'm not sure if the test is invalid.. or if there's something else broken.
   
    or if the change is good after all.
   
   
    Can you review it please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1150
 
    Actually the test failing contradicts the test you added on openwire/MQTT... so I will just remove the test...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

asfgit
In reply to this post by asfgit
Github user dejanb commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1150
 
    @clebertsuconic I found original Jiras why this test was added
   
    https://issues.apache.org/jira/browse/AMQ-4884
    https://issues.apache.org/jira/browse/AMQ-5074
   
    I think we should support this, so I'll take more look into it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

RE: [GitHub] activemq-artemis pull request #1150: NO-JIRA Fixing testReceiveWildcardTopic...

de la Hunt, Craig (RBI-UK)
In reply to this post by asfgit
unsubscribe
-----Original Message-----
From: clebertsuconic [mailto:[hidden email]]
Sent: Wednesday, 29 March 2017 4:15 AM
To: [hidden email]
Subject: [GitHub] activemq-artemis pull request #1150: NO-JIRA Fixing testReceiveWildcardTopic...

GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1150

    NO-JIRA Fixing testReceiveWildcardTopicMatchDoubleWildcard

    Fixing JmsTopicWildcardSendReceiveTest::testReceiveWildcardTopicMatchDoubleWildcard
   
    Accordingly to bisect, this test was broken at 21b64b3e4f4fc6dbeaa30ce610ecefa15110100a

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis openwire

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1150.patch

To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message:

    This closes #1150
   
----
commit d49a34c8252c78c01bbeb8b736c50e73267c9e78
Author: Clebert Suconic <[hidden email]>
Date:   2017-03-29T02:11:57Z

    NO-JIRA Fixing testReceiveWildcardTopicMatchDoubleWildcard
   
    Fixing JmsTopicWildcardSendReceiveTest::testReceiveWildcardTopicMatchDoubleWildcard
   
    Accordingly to bisect, this test was broken at 21b64b3e4f4fc6dbeaa30ce610ecefa15110100a

----


---
If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [GitHub] activemq-artemis pull request #1150: NO-JIRA Fixing testReceiveWildcardTopic...

jbertram
Hi, Craig.  The is the "ActiveMQ Developer List."  You can manage your subscription from http://activemq.apache.org/mailing-lists.html.


Justin

----- Original Message -----
From: "Craig de la Hunt (RBI-UK)" <[hidden email]>
To: [hidden email]
Sent: Wednesday, March 29, 2017 6:55:46 AM
Subject: RE: [GitHub] activemq-artemis pull request #1150: NO-JIRA Fixing testReceiveWildcardTopic...

unsubscribe
-----Original Message-----
From: clebertsuconic [mailto:[hidden email]]
Sent: Wednesday, 29 March 2017 4:15 AM
To: [hidden email]
Subject: [GitHub] activemq-artemis pull request #1150: NO-JIRA Fixing testReceiveWildcardTopic...

GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1150

    NO-JIRA Fixing testReceiveWildcardTopicMatchDoubleWildcard

    Fixing JmsTopicWildcardSendReceiveTest::testReceiveWildcardTopicMatchDoubleWildcard
   
    Accordingly to bisect, this test was broken at 21b64b3e4f4fc6dbeaa30ce610ecefa15110100a

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis openwire

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1150.patch

To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message:

    This closes #1150
   
----
commit d49a34c8252c78c01bbeb8b736c50e73267c9e78
Author: Clebert Suconic <[hidden email]>
Date:   2017-03-29T02:11:57Z

    NO-JIRA Fixing testReceiveWildcardTopicMatchDoubleWildcard
   
    Fixing JmsTopicWildcardSendReceiveTest::testReceiveWildcardTopicMatchDoubleWildcard
   
    Accordingly to bisect, this test was broken at 21b64b3e4f4fc6dbeaa30ce610ecefa15110100a

----


---
If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [hidden email] or file a JIRA ticket with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

asfgit
In reply to this post by asfgit
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1150
 
    @clebertsuconic I'm not sure what has happened here.  Is this patch still relevant?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1150
 
    @mtaylor I was going to remove this, then @dejanb said he would look at fixing the test instead...
   
    @dejanb what should we do? fix the test or remove it as I'm patching it here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1150: NO-JIRA Fixing testReceiveWildcardTopicMatchDo...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1150
 
    @dejanb I will merge this PR, if you really want to fix this test you may bring it back later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1150: NO-JIRA Fixing testReceiveWildcardTopic...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1150


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...