[GitHub] activemq-artemis pull request #1125: ARTEMIS-1058 Jars in web tmp dir locked...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
20 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1125: ARTEMIS-1058 Jars in web tmp dir locked...

asfgit
GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1125

    ARTEMIS-1058 Jars in web tmp dir locked on Windows

    The embedded jetty web server's WebAppClassloader holds up
    webapp's jar files and does not release them after close.
    For that reason the web app's temp dir cannot be cleaned up
    on Windows. (Other platforms like Linux doesn't prevent a
    force delete of files even they are not released).
   
    As long as this behavior exists we need to have a workaround
    to let the tmp dir be cleaned up.
   
    It is possible that we use a 'customized' classloader to replace
    jetty's WebAppClassloader, in which we manually iterate every
    JarFile resources and close them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis master_jetty

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1125
   
----
commit 1c85570d926ce1a51a34523eadab9e1714a498f2
Author: Howard Gao <[hidden email]>
Date:   2017-03-23T13:45:12Z

    ARTEMIS-1058 Jars in web tmp dir locked on Windows
   
    The embedded jetty web server's WebAppClassloader holds up
    webapp's jar files and does not release them after close.
    For that reason the web app's temp dir cannot be cleaned up
    on Windows. (Other platforms like Linux doesn't prevent a
    force delete of files even they are not released).
   
    As long as this behavior exists we need to have a workaround
    to let the tmp dir be cleaned up.
   
    It is possible that we use a 'customized' classloader to replace
    jetty's WebAppClassloader, in which we manually iterate every
    JarFile resources and close them.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    Some googling: https://wiki.eclipse.org/Jetty/Howto/Deal_with_Locked_Windows_Files


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @clebertsuconic  I don't think this is the case. All files except Jar files in web-inf/lib can be deleted automatically. This is because the classloader didn't release the inputstream on Jar files, it relies on GC to close the streams, which you never be sure when to happen.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @gaohoward I would rather keep this unfixed.. and raise an issue to Jetty, than writing a customizeable classLoader. .that will be unmaintainable..  it's out of our scope IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @clebertsuconic I'm fine with that. However we should keep the test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @gaohoward the test will pass?
   
    I don't want any more noise on the testsuite :) .. .we have enough ignored tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    no the test only pass on Linux. On windows it fails (without the fix).
    I'm ok with dropping the test too. (It's a simple test anyway, we can add whenever we want).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @gaohoward can you reach Jetty community and ask for help? maybe raise a bug there after a discussion...
   
    Can you point a link here to whatever discussion you open on Jetty?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @gaohoward  I mean, i would rather have it fixed in jetty, or find the proper config for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @clebertsuconic  will do.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @clebertsuconic I submitted an issue and giving a simple test case.
   
    https://github.com/eclipse/jetty.project/issues/1425



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @gaohoward  can you check this? there's an update on the ticket you opened.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user mtaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @howardgao  Hey Howard, I noticed one of the developers from Jetty got back to you with a modified Jetty version to test on Windows.  Can you confirm if this resolves your problem?  It'd be good to give the Jetty devs some feedback so they can get the issue fixed and incorporated into an upcoming version.
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    ok, I'll test. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @gaohoward  any updates?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @gaohoward  you need to either fix this or close this!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1125: ARTEMIS-1058 Jars in web tmp dir locked...

asfgit
In reply to this post by asfgit
Github user gaohoward closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1125


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @clebertsuconic I'll close this because the fix won't be in Artemis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    I thought you would update to a version fixing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1125: ARTEMIS-1058 Jars in web tmp dir locked on Win...

asfgit
In reply to this post by asfgit
Github user gaohoward commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1125
 
    @clebertsuconic ok I'll update the version on the Jira.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...