[GitHub] activemq-artemis pull request #1110: Fixing expiry on AMQP

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1110: Fixing expiry on AMQP

clebertsuconic-3
GitHub user clebertsuconic opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1110

    Fixing expiry on AMQP

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/clebertsuconic/activemq-artemis expiry

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1110
   
----
commit 7ac27df7a0208714d70b920c1be9635bf0097eec
Author: Jiri Danek <[hidden email]>
Date:   2017-03-20T09:38:05Z

    ARTEMIS-1052 adding a test for expiry and AMQP
   
    This closes #1106

commit 9ed3ee327dfc2a980deb990fca970a17664eb8c2
Author: Clebert Suconic <[hidden email]>
Date:   2017-03-20T16:24:42Z

    ARTEMIS-1052 Proper Expiry over AMQP

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1110: Fixing expiry on AMQP

clebertsuconic-3
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1110
 
    closing this PR will automatically close #1106 as my commit is referencing that one with a asfgit bot message.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1110: Fixing expiry on AMQP

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1110#discussion_r107030877
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/SendingAndReceivingTest.java ---
    @@ -91,6 +95,45 @@ public void testSendingBigMessage() throws Exception {
           }
        }
     
    +   @Test(timeout = 60000)
    +   public void testSendMessageThenAllowToExpireUsingTimeToLive() throws Exception {
    +      AddressSettings as = new AddressSettings();
    +      as.setExpiryAddress(SimpleString.toSimpleString("DLQ"));
    +      HierarchicalRepository<AddressSettings> repos = server.getAddressSettingsRepository();
    +      repos.addMatch("exampleQueue", as);
    +
    +      Connection connection = null;
    +      ConnectionFactory connectionFactory = new JmsConnectionFactory("amqp://localhost:61616");
    +
    +      try {
    +         connection = connectionFactory.createConnection();
    +         Session session = connection.createSession(false, Session.AUTO_ACKNOWLEDGE);
    +         String address = "exampleQueue";
    +         Queue queue = session.createQueue(address);
    +
    +         MessageProducer sender = session.createProducer(queue);
    +         sender.setTimeToLive(10);
    +
    +         Message message = session.createMessage();
    +         sender.send(message);
    +         connection.start();
    +
    +         MessageConsumer consumer = session.createConsumer(queue);
    +         Message m = consumer.receive(5000);
    --- End diff --
   
    there must be a way to not to spend 5s waiting here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1110: Fixing expiry on AMQP

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1110
 
    failure is unrelated to my changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1110: Fixing expiry on AMQP

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1110


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---