Quantcast

[GitHub] activemq-artemis pull request #1098: ARTEMIS-1042 - support amqp failover li...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1098: ARTEMIS-1042 - support amqp failover li...

jdanekrh
GitHub user andytaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1098

    ARTEMIS-1042 - support amqp failover list

    https://issues.apache.org/jira/browse/ARTEMIS-1042

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andytaylor/activemq-artemis amqp_failover

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1098.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1098
   
----
commit b0bdc9447d8bbf81e7fc1157b02631e62fc20804
Author: Andy Taylor <[hidden email]>
Date:   2017-02-28T10:05:39Z

    ARTEMIS-1042 - support amqp failover list
   
    https://issues.apache.org/jira/browse/ARTEMIS-1042

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1098: ARTEMIS-1042 - support amqp failover li...

jdanekrh
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1098#discussion_r106419741
 
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/TopologyMemberImpl.java ---
    @@ -129,6 +131,22 @@ public String toURI() {
           return "tcp://" + host + ":" + port;
        }
     
    +   public URI toBackupURI() {
    +      TransportConfiguration backupConnector = getBackup();
    +      if (backupConnector == null) {
    +         return null;
    --- End diff --
   
    Instead of returning null, can't we return the other members on the list?
   
    I foresee a lot of cases where users don't have backup servers on the cloud.. and just have the infra-structure reconnecting them from data.
   
    Can you provide other nodes as a list here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1098: ARTEMIS-1042 - support amqp failover li...

jdanekrh
In reply to this post by jdanekrh
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1098


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...