Quantcast

[GitHub] activemq-artemis pull request #1093: ARTEMIS-994 Support Netty Native Epoll ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
34 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

asfgit
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1093
 
    i turned on the netty leak detector:
   
    22:55:59,492 SEVERE [io.netty.util.ResourceLeakDetector] LEAK: ByteBuf.release() was not called before it's garbage-collected. See http://netty.io/wiki/reference-counted-objects.html for more information.
    Recent access records: 4
    #4:
    io.netty.buffer.AdvancedLeakAwareByteBuf.readBytes(AdvancedLeakAwareByteBuf.java:504)
    io.netty.buffer.WrappedByteBuf.readBytes(WrappedByteBuf.java:661)
    org.apache.activemq.artemis.protocol.amqp.proton.handler.ProtonHandler.inputBuffer(ProtonHandler.java:182)
    org.apache.activemq.artemis.protocol.amqp.proton.AMQPConnectionContext.inputBuffer(AMQPConnectionContext.java:110)
    org.apache.activemq.artemis.protocol.amqp.broker.ActiveMQProtonRemotingConnection.bufferReceived(ActiveMQProtonRemotingConnection.java:134)
    org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl$DelegatingBufferHandler.bufferReceived(RemotingServiceImpl.java:629)
    org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.channelRead(ActiveMQChannelHandler.java:68)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:363)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:349)
    io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:341)
    io.netty.handler.codec.ByteToMessageDecoder.handlerRemoved(ByteToMessageDecoder.java:219)
    io.netty.channel.DefaultChannelPipeline.callHandlerRemoved0(DefaultChannelPipeline.java:631)
    io.netty.channel.DefaultChannelPipeline.remove(DefaultChannelPipeline.java:468)
    io.netty.channel.DefaultChannelPipeline.remove(DefaultChannelPipeline.java:428)
    org.apache.activemq.artemis.core.protocol.ProtocolHandler$ProtocolDecoder.decode(ProtocolHandler.java:185)
    io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:411)
    io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:248)
    org.apache.activemq.artemis.core.protocol.ProtocolHandler$ProtocolDecoder.channelRead(ProtocolHandler.java:128)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:363)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:349)
    io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:341)
    io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1334)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:363)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:349)
    io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:926)
    io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:1018)
    io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:394)
    io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:299)
    io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858)
    java.lang.Thread.run(Thread.java:745)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

asfgit
In reply to this post by asfgit
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1093
 
    Also:
   
    #1:
    io.netty.buffer.AdvancedLeakAwareByteBuf.writeBytes(AdvancedLeakAwareByteBuf.java:600)
    io.netty.buffer.AbstractByteBuf.readBytes(AbstractByteBuf.java:829)
    io.netty.buffer.WrappedByteBuf.readBytes(WrappedByteBuf.java:616)
    io.netty.buffer.AdvancedLeakAwareByteBuf.readBytes(AdvancedLeakAwareByteBuf.java:469)
    io.netty.handler.codec.ByteToMessageDecoder.handlerRemoved(ByteToMessageDecoder.java:217)
    io.netty.channel.DefaultChannelPipeline.callHandlerRemoved0(DefaultChannelPipeline.java:631)
    io.netty.channel.DefaultChannelPipeline.remove(DefaultChannelPipeline.java:468)
    io.netty.channel.DefaultChannelPipeline.remove(DefaultChannelPipeline.java:428)
    org.apache.activemq.artemis.core.protocol.ProtocolHandler$ProtocolDecoder.decode(ProtocolHandler.java:185)
    io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:411)
    io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:248)
    org.apache.activemq.artemis.core.protocol.ProtocolHandler$ProtocolDecoder.channelRead(ProtocolHandler.java:128)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:363)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:349)
    io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:341)
    io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1334)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:363)
    io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:349)
    io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:926)
    io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:1018)
    io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:394)
    io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:299)
    io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:858)
    java.lang.Thread.run(Thread.java:745)
   



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1093
 
    @michaelandrepearce that's what I was going after.. some sort of leak while dealing with AMQP.
   
    I will review it this week.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1093
 
    I think I got to the bottom of this... there was a leak.. and some proton miss use.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1093
 
    @michaelandrepearce did you ammend anything on your PR? I can't build it any longer (especially outside of Linux.. like on a mac).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

asfgit
In reply to this post by asfgit
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1093
 
    No haven't touched it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

asfgit
In reply to this post by asfgit
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1093
 
    @clebertsuconic i just did a complete fresh clone and rebuild of this PR/My branch which i rebased the other day. It still built ok for me. Should i rebase again? Maybe some commit in the last few days might have broken something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

Michael André Pearce
Hi Clebert

Any luck getting it building?

Did you take my branch or did you take the pr and apply to a local fork/branch with other changes? If so can you point me to that so I can see what is up.

Also re the amqp stuff, I see a lot of upstream changes if I take latest now is that expected to resolve the proton memory issue seen during load test with quiver that was stopping this being merged?

Cheers
Mike





Sent from my iPhone

> On 22 Mar 2017, at 07:19, michaelandrepearce <[hidden email]> wrote:
>
> Github user michaelandrepearce commented on the issue:
>
>    https://github.com/apache/activemq-artemis/pull/1093
>
>    @clebertsuconic i just did a complete fresh clone and rebuild of this PR/My branch which i rebased the other day. It still built ok for me. Should i rebase again? Maybe some commit in the last few days might have broken something?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at [hidden email] or file a JIRA ticket
> with INFRA.
> ---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

clebertsuconic
I can't make it to build on mac and windows.


I need to make some changes also as we talked.  I was using this to test
the proton changes. It works and builds on Linux.  Need to fix the build on
mac and windows now.




On Wed, Mar 22, 2017 at 10:38 PM Michael André Pearce <
[hidden email]> wrote:

> Hi Clebert
>
> Any luck getting it building?
>
> Did you take my branch or did you take the pr and apply to a local
> fork/branch with other changes? If so can you point me to that so I can see
> what is up.
>
> Also re the amqp stuff, I see a lot of upstream changes if I take latest
> now is that expected to resolve the proton memory issue seen during load
> test with quiver that was stopping this being merged?
>
> Cheers
> Mike
>
>
>
>
>
> Sent from my iPhone
>
> > On 22 Mar 2017, at 07:19, michaelandrepearce <[hidden email]> wrote:
> >
> > Github user michaelandrepearce commented on the issue:
> >
> >    https://github.com/apache/activemq-artemis/pull/1093
> >
> >    @clebertsuconic i just did a complete fresh clone and rebuild of this
> PR/My branch which i rebased the other day. It still built ok for me.
> Should i rebase again? Maybe some commit in the last few days might have
> broken something?
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at [hidden email] or file a JIRA
> ticket
> > with INFRA.
> > ---
>
--
Clebert Suconic
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

Michael André Pearce
That's odd re Mac not building for you, my laptop is MacBook and primary dev env , as noted i rebuilt to recheck using a fresh clone and wiped my local maven repo, I also built on fedora using aws.

What is the extract failure you're seeing?




> On 23 Mar 2017, at 02:58, Clebert Suconic <[hidden email]> wrote:
>
> I can't make it to build on mac and windows.
>
>
> I need to make some changes also as we talked.  I was using this to test
> the proton changes. It works and builds on Linux.  Need to fix the build on
> mac and windows now.
>
>
>
>
> On Wed, Mar 22, 2017 at 10:38 PM Michael André Pearce <
> [hidden email]> wrote:
>
>> Hi Clebert
>>
>> Any luck getting it building?
>>
>> Did you take my branch or did you take the pr and apply to a local
>> fork/branch with other changes? If so can you point me to that so I can see
>> what is up.
>>
>> Also re the amqp stuff, I see a lot of upstream changes if I take latest
>> now is that expected to resolve the proton memory issue seen during load
>> test with quiver that was stopping this being merged?
>>
>> Cheers
>> Mike
>>
>>
>>
>>
>>
>> Sent from my iPhone
>>
>>> On 22 Mar 2017, at 07:19, michaelandrepearce <[hidden email]> wrote:
>>>
>>> Github user michaelandrepearce commented on the issue:
>>>
>>>   https://github.com/apache/activemq-artemis/pull/1093
>>>
>>>   @clebertsuconic i just did a complete fresh clone and rebuild of this
>> PR/My branch which i rebased the other day. It still built ok for me.
>> Should i rebase again? Maybe some commit in the last few days might have
>> broken something?
>>>
>>>
>>> ---
>>> If your project is set up for it, you can reply to this email and have
>> your
>>> reply appear on GitHub as well. If your project does not have this
>> feature
>>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>>> contact infrastructure at [hidden email] or file a JIRA
>> ticket
>>> with INFRA.
>>> ---
>>
> --
> Clebert Suconic
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

clebertsuconic
Not finding epoll pakcets on netty connector.


Now that you mentioned. I think rebuilt netty.  And I provably did
something wrong.


Will redo in the morning with a fresh Maven.  Going to sleep now :)


On Wed, Mar 22, 2017 at 11:27 PM Michael André Pearce <
[hidden email]> wrote:

> That's odd re Mac not building for you, my laptop is MacBook and primary
> dev env , as noted i rebuilt to recheck using a fresh clone and wiped my
> local maven repo, I also built on fedora using aws.
>
> What is the extract failure you're seeing?
>
>
>
>
> > On 23 Mar 2017, at 02:58, Clebert Suconic <[hidden email]>
> wrote:
> >
> > I can't make it to build on mac and windows.
> >
> >
> > I need to make some changes also as we talked.  I was using this to test
> > the proton changes. It works and builds on Linux.  Need to fix the build
> on
> > mac and windows now.
> >
> >
> >
> >
> > On Wed, Mar 22, 2017 at 10:38 PM Michael André Pearce <
> > [hidden email]> wrote:
> >
> >> Hi Clebert
> >>
> >> Any luck getting it building?
> >>
> >> Did you take my branch or did you take the pr and apply to a local
> >> fork/branch with other changes? If so can you point me to that so I can
> see
> >> what is up.
> >>
> >> Also re the amqp stuff, I see a lot of upstream changes if I take latest
> >> now is that expected to resolve the proton memory issue seen during load
> >> test with quiver that was stopping this being merged?
> >>
> >> Cheers
> >> Mike
> >>
> >>
> >>
> >>
> >>
> >> Sent from my iPhone
> >>
> >>> On 22 Mar 2017, at 07:19, michaelandrepearce <[hidden email]>
> wrote:
> >>>
> >>> Github user michaelandrepearce commented on the issue:
> >>>
> >>>   https://github.com/apache/activemq-artemis/pull/1093
> >>>
> >>>   @clebertsuconic i just did a complete fresh clone and rebuild of this
> >> PR/My branch which i rebased the other day. It still built ok for me.
> >> Should i rebase again? Maybe some commit in the last few days might have
> >> broken something?
> >>>
> >>>
> >>> ---
> >>> If your project is set up for it, you can reply to this email and have
> >> your
> >>> reply appear on GitHub as well. If your project does not have this
> >> feature
> >>> enabled and wishes so, or if the feature is enabled but not working,
> >> please
> >>> contact infrastructure at [hidden email] or file a JIRA
> >> ticket
> >>> with INFRA.
> >>> ---
> >>
> > --
> > Clebert Suconic
>
--
Clebert Suconic
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1093: ARTEMIS-994 Support Netty Native Epoll ...

asfgit
In reply to this post by asfgit
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1093


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

asfgit
In reply to this post by asfgit
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1093
 
    Please review master ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1093: ARTEMIS-994 Support Netty Native Epoll on Linu...

asfgit
In reply to this post by asfgit
Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1093
 
    Many thanks Clebert.
   
    Had a brief look over tonight. Seems good. Will spend a bit more time tomorrow and also take the chance to update my fork.
   
    Sent from my iPhone
   
    > On 24 Mar 2017, at 00:47, clebertsuconic <[hidden email]> wrote:
    >
    > Please review master ?
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub, or mute the thread.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
12
Loading...