[GitHub] activemq-artemis pull request #1025: ARTEMIS-977 - record id of address not ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1025: ARTEMIS-977 - record id of address not ...

tabish121-2
GitHub user andytaylor opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1025

    ARTEMIS-977 - record id of address not set on journal reload

    https://issues.apache.org/jira/browse/ARTEMIS-977

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andytaylor/activemq-artemis ARTEMIS-977

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1025.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1025
   
----
commit 9d7e4d29e5fc24e1d926dc89e23a52906bc736b2
Author: Andy Taylor <[hidden email]>
Date:   2017-02-17T11:20:51Z

    ARTEMIS-977 - record id of address not set on journal reload
   
    https://issues.apache.org/jira/browse/ARTEMIS-977

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1025: ARTEMIS-977 - record id of address not ...

tabish121-2
Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1025#discussion_r101742074
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java ---
    @@ -412,6 +412,27 @@ public void testGetAddressNames() throws Exception {
        }
     
        @Test
    +   public void testGetAddressDeletedFromJournal() throws Exception {
    --- End diff --
   
    This test is passing for me even without the change in PostOfficeJournalLoader.java.
   
    I wanted to figure out why I was not able to reproduce this with JUnit test the day before yesterday and I noticed what I said in the first paragraph. Do you have any ideas what might be wrong?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1025: ARTEMIS-977 - record id of address not set on ...

tabish121-2
In reply to this post by tabish121-2
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1025
 
    dont merge this just yet


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1025: ARTEMIS-977 - record id of address not set on ...

tabish121-2
In reply to this post by tabish121-2
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1025
 
    ok, good to go


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1025: ARTEMIS-977 - record id of address not ...

tabish121-2
In reply to this post by tabish121-2
Github user jdanekrh commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1025#discussion_r101748679
 
    --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java ---
    @@ -412,6 +412,27 @@ public void testGetAddressNames() throws Exception {
        }
     
        @Test
    +   public void testGetAddressDeletedFromJournal() throws Exception {
    --- End diff --
   
    Now it is working for me as it should.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1025: ARTEMIS-977 - record id of address not set on ...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1025
 
    I'm running tests to make sure before merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1025: ARTEMIS-977 - record id of address not set on ...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1025
 
    there seems to be a checkstyle issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1025: ARTEMIS-977 - record id of address not set on ...

tabish121-2
In reply to this post by tabish121-2
Github user andytaylor commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1025
 
    I didnt see an issue when i built locally


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis issue #1025: ARTEMIS-977 - record id of address not set on ...

tabish121-2
In reply to this post by tabish121-2
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1025
 
    There's actually a checkstyle issue. It's a minor thing. a space on a line.
   
   
    if you can't fix it this monday I will amend myself and push it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|

[GitHub] activemq-artemis pull request #1025: ARTEMIS-977 - record id of address not ...

tabish121-2
In reply to this post by tabish121-2
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1025


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---