Quantcast

[GitHub] activemq-artemis pull request #1015: https://issues.apache.org/jira/browse/A...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1015: https://issues.apache.org/jira/browse/A...

clebertsuconic-3
GitHub user cshannon opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1015

    https://issues.apache.org/jira/browse/ARTEMIS-964

    Moving XML conversion logic to a common XmlDataExporterUtil class so it
    can be used elsewhere.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-964

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1015
   
----
commit af1a205dc58f7309f9aedb28285c2ff598da8514
Author: Christopher L. Shannon (cshannon) <[hidden email]>
Date:   2017-02-14T16:09:44Z

    https://issues.apache.org/jira/browse/ARTEMIS-964
   
    Moving XML conversion logic to a common XmlDataExporterUtil class so it
    can be used elsewhere.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1015: https://issues.apache.org/jira/browse/ARTEMIS-...

clebertsuconic-3
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1015
 
    @cshannon it looks good...
   
    just one minor thing.. I have been trying to keep the commit message understandable at the first line...
   
   
    something like:
   
    ```
    ARTEMIS-964 Moving XML Conversion to blablabla
   
    https://issues.apache.org/jira/browse/ARTEMIS-964
    more blablablablablal...
    ```
   
   
    We have that on the hacking guide...
   
   
   
    you are a committer, you could of course bypass the "rule" if you have a strong feeling for this format.. .but it's just that this is helpful when doing bisects and git logs... I have had to bisect before and reading stuff on the first line would be helpful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1015: https://issues.apache.org/jira/browse/ARTEMIS-...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1015
 
    @clebertsuconic, I had a similar thought as you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1015: https://issues.apache.org/jira/browse/ARTEMIS-...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user cshannon commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1015
 
    I changed the commit message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1015: https://issues.apache.org/jira/browse/A...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1015


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1015: https://issues.apache.org/jira/browse/ARTEMIS-...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1015
 
    Nice one!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1015: https://issues.apache.org/jira/browse/ARTEMIS-...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1015
 
    @cshannon  ðŸ‘


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...