Quantcast

[GitHub] activemq-artemis pull request #1014: [ARTEMIS-963]Â Prevent ClassCastExcepti...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1014: [ARTEMIS-963]Â Prevent ClassCastExcepti...

clebertsuconic-3
GitHub user jmesnil opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1014

    [ARTEMIS-963] Prevent ClassCastException in ActiveMQChannelHandler

    When HTTP Upgrade is enabled, update Netty's pipeline only after the
    HTTP Upgrade handshake is successful *and* the trailing
    EMPTY_LAST_CONTENT is received.
    Otherwise, this EMPTY_LAST_CONTENT is handled by
    ActiveMQChannelHandler which is only expected to handle ByteBuf
   
    JIRA: https://issues.apache.org/jira/browse/ARTEMIS-963

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jmesnil/activemq-artemis ARTEMIS-963_ClassCastException_ActiveMQChannelHandler_1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1014.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1014
   
----
commit 4b10228e1db5ffe334a3934c73ce835571ea2096
Author: Jeff Mesnil <[hidden email]>
Date:   2017-02-14T14:25:39Z

    [ARTEMIS-963] Prevent ClassCastException in ActiveMQChannelHandler
   
    When HTTP Upgrade is enabled, update Netty's pipeline only after the
    HTTP Upgrade handshake is successful *and* the trailing
    EMPTY_LAST_CONTENT is received.
    Otherwise, this EMPTY_LAST_CONTENT is handled by
    ActiveMQChannelHandler which is only expected to handle ByteBuf
   
    JIRA: https://issues.apache.org/jira/browse/ARTEMIS-963

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis issue #1014: [ARTEMIS-963]Â Prevent ClassCastException in A...

clebertsuconic-3
Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1014
 
    @jmesnil close this please?
   
    I cherry-picked -x into 1.x


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] activemq-artemis pull request #1014: [ARTEMIS-963]Â Prevent ClassCastExcepti...

clebertsuconic-3
In reply to this post by clebertsuconic-3
Github user jmesnil closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1014


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...