Bug in MemoryMessageStore

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug in MemoryMessageStore

Jerome B
Folks,
  I think there's a bug in line 80 of
org.apache.activemq.store.memory.MemoryMessageStore in the main trunk.

It says
if(lastBatchId!=null&lastBatchId.equals(msgId)){

I think it should say
if(lastBatchId!=null && lastBatchId.equals(msgId)){

 (logical AND vs bitwise AND)

 Could someone fix this in the trunk please?

thx..
Reply | Threaded
Open this post in threaded view
|

Re: Bug in MemoryMessageStore

Guillaume Nodet-4
Thanks ! I have fixed that.
I was having problems too but had not had time to investigate the problem...

On 12/12/06, Jerome Banks <[hidden email]> wrote:

> Folks,
>   I think there's a bug in line 80 of
> org.apache.activemq.store.memory.MemoryMessageStore in the main trunk.
>
> It says
> if(lastBatchId!=null&lastBatchId.equals(msgId)){
>
> I think it should say
> if(lastBatchId!=null && lastBatchId.equals(msgId)){
>
>  (logical AND vs bitwise AND)
>
>  Could someone fix this in the trunk please?
>
> thx..
>
>


--
Cheers,
Guillaume Nodet
Reply | Threaded
Open this post in threaded view
|

Re: Bug in MemoryMessageStore

rajdavies
oops! my bad  -thanks for fixing

cheers,

Rob
On 12 Dec 2006, at 22:49, Guillaume Nodet wrote:

> Thanks ! I have fixed that.
> I was having problems too but had not had time to investigate the  
> problem...
>
> On 12/12/06, Jerome Banks <[hidden email]> wrote:
>> Folks,
>>   I think there's a bug in line 80 of
>> org.apache.activemq.store.memory.MemoryMessageStore in the main  
>> trunk.
>>
>> It says
>> if(lastBatchId!=null&lastBatchId.equals(msgId)){
>>
>> I think it should say
>> if(lastBatchId!=null && lastBatchId.equals(msgId)){
>>
>>  (logical AND vs bitwise AND)
>>
>>  Could someone fix this in the trunk please?
>>
>> thx..
>>
>>
>
>
> --
> Cheers,
> Guillaume Nodet