[1/2] activemq-artemis git commit: This closes #1767

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[1/2] activemq-artemis git commit: This closes #1767

jbertram
Repository: activemq-artemis
Updated Branches:
  refs/heads/master 7377ef7f6 -> 3e41aa151


This closes #1767


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/3e41aa15
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/3e41aa15
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/3e41aa15

Branch: refs/heads/master
Commit: 3e41aa151d4f6caa910eff8b400af455219ec2e7
Parents: 7377ef7 49b7863
Author: Justin Bertram <[hidden email]>
Authored: Thu Jan 11 11:46:09 2018 -0600
Committer: Justin Bertram <[hidden email]>
Committed: Thu Jan 11 11:46:09 2018 -0600

----------------------------------------------------------------------
 .../spi/core/security/jaas/Krb5LoginModule.java |  5 +-
 .../core/security/jaas/Krb5LoginModuleTest.java | 62 ++++++++++++++++++++
 2 files changed, 66 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


Reply | Threaded
Open this post in threaded view
|

[2/2] activemq-artemis git commit: [ARTEMIS-1597] validate non null callback principal for login success

jbertram
[ARTEMIS-1597] validate non null callback principal for login success


Project: http://git-wip-us.apache.org/repos/asf/activemq-artemis/repo
Commit: http://git-wip-us.apache.org/repos/asf/activemq-artemis/commit/49b7863c
Tree: http://git-wip-us.apache.org/repos/asf/activemq-artemis/tree/49b7863c
Diff: http://git-wip-us.apache.org/repos/asf/activemq-artemis/diff/49b7863c

Branch: refs/heads/master
Commit: 49b7863cf99ae7b7ebbf4dd804010fb7aee649d9
Parents: 7377ef7
Author: gtully <[hidden email]>
Authored: Wed Jan 10 16:33:33 2018 +0000
Committer: Justin Bertram <[hidden email]>
Committed: Thu Jan 11 11:46:09 2018 -0600

----------------------------------------------------------------------
 .../spi/core/security/jaas/Krb5LoginModule.java |  5 +-
 .../core/security/jaas/Krb5LoginModuleTest.java | 62 ++++++++++++++++++++
 2 files changed, 66 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/49b7863c/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/Krb5LoginModule.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/Krb5LoginModule.java b/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/Krb5LoginModule.java
index 3396c81..07cb4c0 100644
--- a/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/Krb5LoginModule.java
+++ b/artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/Krb5LoginModule.java
@@ -58,12 +58,15 @@ public class Krb5LoginModule implements LoginModule {
       callbacks[0] = new Krb5Callback();
       try {
          callbackHandler.handle(callbacks);
+         Principal principal = ((Krb5Callback)callbacks[0]).getPeerPrincipal();
+         if (principal != null) {
+            principals.add(principal);
+         }
       } catch (IOException ioe) {
          throw new LoginException(ioe.getMessage());
       } catch (UnsupportedCallbackException uce) {
          throw new LoginException(uce.getMessage() + " not available to obtain information from user");
       }
-      principals.add(((Krb5Callback)callbacks[0]).getPeerPrincipal());
       if (!principals.isEmpty()) {
          loginSucceeded = true;
       }

http://git-wip-us.apache.org/repos/asf/activemq-artemis/blob/49b7863c/artemis-server/src/test/java/org/apache/activemq/artemis/spi/core/security/jaas/Krb5LoginModuleTest.java
----------------------------------------------------------------------
diff --git a/artemis-server/src/test/java/org/apache/activemq/artemis/spi/core/security/jaas/Krb5LoginModuleTest.java b/artemis-server/src/test/java/org/apache/activemq/artemis/spi/core/security/jaas/Krb5LoginModuleTest.java
new file mode 100644
index 0000000..d8039a9
--- /dev/null
+++ b/artemis-server/src/test/java/org/apache/activemq/artemis/spi/core/security/jaas/Krb5LoginModuleTest.java
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.spi.core.security.jaas;
+
+import org.junit.Test;
+
+import javax.security.auth.Subject;
+import javax.security.auth.callback.Callback;
+import javax.security.auth.callback.CallbackHandler;
+import javax.security.auth.callback.UnsupportedCallbackException;
+
+import java.io.IOException;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+public class Krb5LoginModuleTest {
+
+   @Test
+   public void loginFail() throws Exception {
+      Krb5LoginModule underTest = new Krb5LoginModule();
+
+      final Subject subject = new Subject();
+      underTest.initialize(subject, new CallbackHandler() {
+         @Override
+         public void handle(Callback[] callbacks) throws IOException, UnsupportedCallbackException {
+         }
+      }, null, null);
+
+      assertFalse(underTest.login());
+   }
+
+   @Test
+   public void loginSuccess() throws Exception {
+      Krb5LoginModule underTest = new Krb5LoginModule();
+
+      final Subject subject = new Subject();
+      underTest.initialize(subject, new CallbackHandler() {
+         @Override
+         public void handle(Callback[] callbacks) throws IOException, UnsupportedCallbackException {
+            ((Krb5Callback) callbacks[0]).setPeerPrincipal(new UserPrincipal("A"));
+         }
+      }, null, null);
+
+      assertTrue(underTest.login());
+   }
+
+}